#3347 no send empty list #3455
Merged
#3347 no send empty list #3455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbarreca
requested changes
Sep 8, 2018
| delay(priority: 10). | ||
| seller_order_updated(order, supplier) | ||
| else | ||
| Rollbar.warning("Warning: Trying to send update email (for order id ##{order.id}) to supplier (#{supplier.id} - #{supplier.name}) with 0 users") |
There was a problem hiding this comment.
@ivar I think this warning should be removed. In some markets, there are organizations that are managed by the market manager. For example, you have a farm who can't handle technology so they just call a market manager on the phone and he/she does the order management for them. In this case, an organization could have an empty users list.
There was a problem hiding this comment.
@rbarreca - updated as per your feedback. Please review
rbarreca
added
address comments
ivar
added
ready for review
|
@rbarreca extra space removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue at #3347
seller_order_update_no_recipient_3347branchThe following specs have been reviewed and run green
spec/interactors/send_update_emails_spec.rbspec/mailers/order_mailer_spec.rbspec/models/order_spec.rb