Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the locker core proxying #11

Closed
temas opened this issue Apr 5, 2011 · 3 comments
Closed

Simplify the locker core proxying #11

temas opened this issue Apr 5, 2011 · 3 comments

Comments

@temas
Copy link
Member

temas commented Apr 5, 2011

The proxy functions are mostly mirrored in the GET and POST handlers as well as the proxied() and proxiedPost(). Merge this up. Clean this up. Win.

@smurthas
Copy link
Member

Unicode chars get mashed in the process, this should also be fixed. This can become a second issue if needed.

smurthas added a commit that referenced this issue Apr 12, 2011
Ops/webservice.js: merged proxied and proxiedPost, fixed unicode issues
tests/connector-twitter-test.js: small updates to reflect resolution of proxy issues
tests/locker-core-api-test.js: added better error info for unicode issues
@smurthas
Copy link
Member

The proxy should also respond to and propagate redirects.

smurthas added a commit that referenced this issue Apr 13, 2011
Ops/webservice.js: proxy redirect fixes
tests/Me/proxy-redirect-test/: webservice for testing redirects
tests/locker-issues-test.js: tests for proxy redirect
Connectors/Twitter/client.js: Small bug fixes to error states
@smurthas
Copy link
Member

This is resolved as of the referenced commit. Closing.

temas pushed a commit that referenced this issue Apr 14, 2011
* Common/node/locker.js
    - Remove the id from a few more function calls
* Connectors/Facebook/client.js
    - Updates to the new locker client interfaces
* Connectors/Flickr/client.js
    - Updates to the new locker client interfaces
* Connectors/Twitter/client.js
    - Updates to the new locker client interfaces
* Connectors/foursquare/client.js
    - Updates to the new locker client interfaces
* tests/connector-flickr-test.js
    - Updates to the new locker client interfaces
* tests/locker-client-tests.js
    - Added the event test

All tests pass except for the issue #11 test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants