Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration #5

Open
nlemoine opened this issue Sep 15, 2020 · 9 comments
Open

Registration #5

nlemoine opened this issue Sep 15, 2020 · 9 comments

Comments

@nlemoine
Copy link
Contributor

nlemoine commented Sep 15, 2020

Hi,

Thanks for this great little plugin which provides login customization in no time!

There's a little issue with the registration form:

Capture d’écran 2020-09-15 à 10 49 15

Maybe it would be more secure to set a safer base text color?

@Log1x
Copy link
Owner

Log1x commented Sep 15, 2020

I don't have any sites with registration open so I didn't really think of this. None of the styles were meant target the register form in particular but I will try to push a fix when I get time so it works nicely.

@nlemoine
Copy link
Contributor Author

Thanks @Log1x !

@Log1x Log1x closed this as completed in 7f1f480 Sep 15, 2020
@Log1x
Copy link
Owner

Log1x commented Sep 15, 2020

let me know if the update I pushed works. I don't have a complex register form to test against

@nlemoine
Copy link
Contributor Author

Thanks, that's better.

Some texts are still white on white. I'll have a look as soon as I can.

Capture d’écran 2020-09-15 à 18 02 45

@nlemoine
Copy link
Contributor Author

The admin email verification screen also suffers the same issue.

Capture d’écran 2020-09-17 à 12 20 41

@Log1x Log1x reopened this Sep 17, 2020
@pablobh
Copy link
Contributor

pablobh commented Apr 11, 2021

Is this still a problem? I may be able to help

@nlemoine
Copy link
Contributor Author

It is! I started working on this a while ago but it's missing a dev environment and testing all use cases is a bit tedious.

Maybe dumping static HTML (login.html, lost-password.html, etc.) would make dev/testing easier?

@pablobh
Copy link
Contributor

pablobh commented Apr 13, 2021

@nlemoine That may be easier for me. That way I'll have all the fields from your custom registration.

Also, a few days ago I did a few fixes to a couple of css classes, can you confirm that the problem is still there after this update?

nlemoine added a commit to nlemoine/modern-login that referenced this issue May 5, 2021
@nlemoine
Copy link
Contributor Author

nlemoine commented May 5, 2021

@pablobh Sorry, I didn't have time to work this until now.

You'll find in the referenced PR a testing environnement that will make fixing a lot easier.

Also, a few days ago I did a few fixes to a couple of css classes, can you confirm that the problem is still there after this update?

It's better in some cases but I think there's still some improvements to be done.

localhost_3000_wp-login php_action=register
localhost_3000_wp-login php_action=register (1)

But hopefully, if the PR gets merged, it will be easier to discuss and test things ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants