Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TailwindCSS/dependencies / add testing environment #10

Merged
merged 3 commits into from
Jan 27, 2022

Conversation

nlemoine
Copy link
Contributor

@nlemoine nlemoine commented May 5, 2021

# Conflicts:
#	assets/css/login.css
#	public/css/login.css
#	public/mix-manifest.json
@pablobh
Copy link
Contributor

pablobh commented May 11, 2021

Great work on the dev enviroment!

@Log1x Log1x self-requested a review May 18, 2021 22:45
@Log1x Log1x self-assigned this May 18, 2021
@nlemoine
Copy link
Contributor Author

nlemoine commented Jan 27, 2022

Hello @Log1x,

5.9 introduced a new languages switcher on the login form which breaks the current styles (see screenshot below).

I also updated the testing environment to make use of the awesome wp-env package.

Can you have a look at this PR?

Capture d’écran 2022-01-27 à 10 28 12

@Log1x Log1x merged commit 58182ca into Log1x:master Jan 27, 2022
@Log1x
Copy link
Owner

Log1x commented Jan 27, 2022

thank you for this. very sorry for the delay.

@nlemoine
Copy link
Contributor Author

No problem, note that the language switcher issue was quickly fixed. It appears at the bottom of the page and not right under the login form like the regular login form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants