Updated Smart Logging for 1.7.2 and resolved a bug with door logging #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is test btw |
|
been running OK on my server for a couple of days, though I've not done any focused testing of e.g. doors |
|
It's a relatively minor change. Appears doors Material wasn't right, and I added in the new tall grass to basically the same system, as well as refactoring the check to determine whether a block is on the top half of a two block tall structure or the bottom half into one check. |
|
I tested this for doors, and all 5 new types of plant by breaking the block below them, the block that is their base, and their top half. In all three cases all destroyed blocks were properly logged. |
|
Although I just realized I /did/ forget to change a number. |
|
There initial capacity has been increased properly for 1.7.2 relativeTopBreakables. |
frymaster
added a commit
that referenced
this pull request
Jan 20, 2014
Updated Smart Logging for 1.7.2 and resolved a bug with door logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.