Support Worldedit 6.0 API instead of legacy API #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into DarkArc-worldedit-6.0.0 Conflicts: src/main/java/de/diddiz/LogBlock/LogBlock.java src/main/java/de/diddiz/LogBlock/listeners/ExplosionLogging.java src/main/java/de/diddiz/worldedit/LogBlockEditSession.java Update Worldedit 6.0 hook to support UUIDs
| final de.diddiz.LogBlock.Actor lbActor = AtoA(actor); | ||
|
|
||
| // Check to ensure the world should be logged | ||
| String worldName = event.getWorld().getName(); |
There was a problem hiding this comment.
getWorld() is Marked as @nullable, potential NPE?
Directly get the Bukkit World object of the event, if possible Move Worldedit World -> Bukkit World conversion to a separate method
frymaster
force-pushed
the
DarkArc-worldedit-6.0.0
branch
from
29187c1
to
d48d042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #541 #572, #557
Breaks support for older versions of Worldedit. Adds support for newer versions. This is @DarkArc's PR with the minimal changes needed for it to return UUID information instead of name strings. Tested briefly and so far it seems to work...