Ensure channels output 0v on startup #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In base Hemisphere, APP_MIDI's Reset would set all channels to 0 when the device restarted. After removing APP_MIDI, this no longer happens. Consequently, the channels output ~6v on startup and don't drop back down until an applet outputs a specific value to a channel. This can cause problems such as Stairs BOC trigger not being detectable on first reset. This commit fixes this by setting all channels to 0v on APP_HEMISPHERE's init.
qiemem
pushed a commit
to qiemem/O_C-HemisphereSuite
that referenced
this pull request
Jan 28, 2022
Shredder applet
suit4
added a commit
to suit4/O_C-HemisphereSuite
that referenced
this pull request
Jun 17, 2022
suit4
added a commit
to suit4/O_C-HemisphereSuite
that referenced
this pull request
Jun 17, 2022
suit4
added a commit
to suit4/O_C-HemisphereSuite
that referenced
this pull request
Jun 17, 2022
Adding BigScope App – Changes from pull request Chysn#76 Changes from pull request Chysn#51 Changes from pull request Chysn#105 Changes from pull request Logarhythm1#2
suit4
added a commit
to suit4/O_C-HemisphereSuite
that referenced
this pull request
Jun 17, 2022
Adding BigScope App – Changes from pull request Chysn#76 Changes from pull request Chysn#51 Changes from pull request Chysn#105 Changes from pull request Logarhythm1#2
|
Thanks Qiemem, apologies for not updating in forever! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In base Hemisphere, APP_MIDI's Reset would set all channels to 0 when the device restarted. After removing APP_MIDI, this no longer happens. Consequently, the channels output ~6v on startup and don't drop back down until an applet outputs a specific value to a channel. This can cause problems such as Stairs BOC trigger not being detectable on first reset.
This PR fixes this by setting all channels to 0v on APP_HEMISPHERE's init.