Preventing move from getting a negative balance

Lohoris · Dec 6, 2012 · 4442224 · 4442224
1 parent 0a4e67a
commit 4442224
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/rpcwallet.cpp b/src/rpcwallet.cpp
@@ -558,13 +558,17 @@ Value movecmd(const Array& params, bool fHelp)
     string strFrom = AccountFromValue(params[0]);
     string strTo = AccountFromValue(params[1]);
     int64 nAmount = AmountFromValue(params[2]);
+    int nMinDepth = 1;
     if (params.size() > 3)
-        // unused parameter, used to be nMinDepth, keep type-checking it though
-        (void)params[3].get_int();
+        nMinDepth = params[3].get_int();
     string strComment;
     if (params.size() > 4)
         strComment = params[4].get_str();
-
+
+	int64 nBalance = GetAccountBalance(strFrom, nMinDepth);
+	if (nBalance < nAmount)
+		throw JSONRPCError(-6, "Account has insufficient funds");
+
     CWalletDB walletdb(pwalletMain->strWalletFile);
     if (!walletdb.TxnBegin())
         throw JSONRPCError(-20, "database error");