-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use per-line spell-checking ignore pattern and remove one-off ignores (OSOE-491) #134
Comments
Tested this in Lombiq/UI-Testing-Toolbox@175018a (because of #103), but didn't work ("lombiquitestingtoolbox" occurs only once in the whole solution), then also tried |
Oh, never mind, I thought this pattern is already active from the original action, but instead we need to add it to our own patterns. |
Is this still applicable after #103 @BenedekFarkas? |
Yep! I added the line ignore pattern ( |
Got it, thanks. |
Will be done in Lombiq/Open-Source-Orchard-Core-Extensions#346 / OSOE-523 instead. |
With the
check-spelling
action it's possible to mark lines with a custom pattern so they're excluded from spell-checking. See from this comment. We should do this instead of adding ignores globally that are only used in a single file (or single instance).#spell-check-ignore-line
is OK for this, since it just needs to be included at the end of the line, but the line can otherwise contain anything. So, e.g. in C#, it can be in a//
comment. Note that in this PR the pattern was already configured.Jira issue
The text was updated successfully, but these errors were encountered: