OSOE-84: New words to allow for Node.js Extensions #186
Conversation
- that happened because I had reverted the accidental merge of OSOE-84-final into dev
# Conflicts: # .github/actions/spelling/action.yml # .github/actions/spelling/excludes.txt # .github/actions/spelling/expect.txt
# Conflicts: # .github/actions/spelling/allow.txt # .github/actions/spelling/excludes.txt # .github/actions/spelling/expect.txt # Docs/Workflows.md
# Conflicts: # .github/actions/spelling/allow.txt # .github/actions/spelling/excludes.txt
# Conflicts: # .github/actions/spelling/allow.txt
# Conflicts: # .github/actions/spelling/allow.txt
| @@ -8,17 +8,21 @@ apiclienttenant | |||
| apikey | |||
| apps | |||
| appsettings | |||
| argv | |||
There was a problem hiding this comment.
Some of these look generic enough for the common configuration, but some very rare. For the latter, rather use #spell-check-ignore-line
There was a problem hiding this comment.
Actually, most of those rare words are simply specific to NE. Are we planning to support project-level dictionaries anytime soon (@BenedekFarkas)? Because then I'd rather move them into one of those than commenting them everywhere.
There was a problem hiding this comment.
Yeah, good point, the spelling configuration in most repositories (but definitely in OSOCE) will be completely overhauled in Lombiq/Open-Source-Orchard-Core-Extensions#346.
So, you can apply the current practices to make it easier on rolling this out without having to worry about upcoming changes.
See my comment about using per-line ignores here: #134 (comment)
If you can expect that a specific word will appear in more places in the future, then putting it in a dictionary is OK. Based on applying this concept to OrchardCMS/OrchardCore.Commerce#250 and some other repos, I'd say that maximum 1 or 2 occurrences of a rare word (if you don't expect more) is OK to ignore.
There was a problem hiding this comment.
For the record - all errors by the spell checker when no new entries are added:
Autoprefixis not a recognized word. (unrecognized-spelling)
EBUSYis not a recognized word. (unrecognized-spelling)
EOLis not a recognized word. (unrecognized-spelling)
EOLis not a recognized word. (unrecognized-spelling)
EOLis not a recognized word. (unrecognized-spelling)
Lintrcis not a recognized word. (unrecognized-spelling)
Lintrcis not a recognized word. (unrecognized-spelling)
Promisifiedis not a recognized word. (unrecognized-spelling)
Resxis not a recognized word. (unrecognized-spelling)
argvis not a recognized word. (unrecognized-spelling)
argvis not a recognized word. (unrecognized-spelling)
argvis not a recognized word. (unrecognized-spelling)
argvis not a recognized word. (unrecognized-spelling)
argvis not a recognized word. (unrecognized-spelling)
binstubsis not a recognized word. (unrecognized-spelling)
chdiris not a recognized word. (unrecognized-spelling)
chdiris not a recognized word. (unrecognized-spelling)
chdiris not a recognized word. (unrecognized-spelling)
chdiris not a recognized word. (unrecognized-spelling)
constitueis not a recognized word. (unrecognized-spelling)
copyfilesis not a recognized word. (unrecognized-spelling)
copyfilesis not a recognized word. (unrecognized-spelling)
copyfilesis not a recognized word. (unrecognized-spelling)
copyfilesis not a recognized word. (unrecognized-spelling)
copyfilesis not a recognized word. (unrecognized-spelling)
erroredis not a recognized word. (unrecognized-spelling)
lintrcis not a recognized word. (unrecognized-spelling)
loglevelis not a recognized word. (unrecognized-spelling)
npmrcis not a recognized word. (check-file-path)
npmrcis not a recognized word. (check-file-path)
npmrcis not a recognized word. (unrecognized-spelling)
promisifyis not a recognized word. (unrecognized-spelling)
promisifyis not a recognized word. (unrecognized-spelling)
symlinkis not a recognized word. (unrecognized-spelling)
symlinkis not a recognized word. (unrecognized-spelling)
symlinkedis not a recognized word. (unrecognized-spelling)
symlinkedis not a recognized word. (unrecognized-spelling)
symlinksis not a recognized word. (unrecognized-spelling)
textlintis not a recognized word. (unrecognized-spelling)
textlintis not a recognized word. (unrecognized-spelling)
textlintis not a recognized word. (unrecognized-spelling)
thenableis not a recognized word. (unrecognized-spelling)
There was a problem hiding this comment.
That's not too bad! Just add them here to allow.txt for now (or ignore in-code whatever you see fit for that) and I'll take care of the rest during the refactoring.
There was a problem hiding this comment.
I did what Zoltán suggested - ignored the rare ones, re-added the common ones.
OSOE-84