Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "advice" instead of "advices" in .github/actions/spelling/advice.md (OSOE-570) #210

Closed
DemeSzabolcs opened this issue Feb 14, 2023 · 3 comments
Assignees

Comments

@DemeSzabolcs
Copy link
Member

DemeSzabolcs commented Feb 14, 2023

Advice is an uncountable noun even if the document has multiple entries it's just collectively advice. It is grammatically incorrect to pluralize it except in specific financial and legal documents (see https://en.wiktionary.org/wiki/advice). Correct it here: https://github.com/Lombiq/GitHub-Actions/blob/dev/.github/actions/spelling/advice.md#spell-checking-configuration-advices:~:text=Spell%20checking%20configuration-,advices,-Basics

Jira issue

@DemeSzabolcs DemeSzabolcs added the good first issue Good for newcomers label Feb 14, 2023
@github-actions github-actions bot changed the title Use "advice" instead of "advices" in .github/actions/spelling/advice.md Use "advice" instead of "advices" in .github/actions/spelling/advice.md (OSOE-570) Feb 14, 2023
@BenedekFarkas
Copy link
Member

BenedekFarkas commented Feb 15, 2023

Isn't this overkill for a separate issue? Unless you created it for someone specifically to practice contributing to multiple repositories with submodules included.

BTW I'm currently working on Lombiq/Open-Source-Orchard-Core-Extensions#346 / OSOE-523, where I'm making changes to every repository involved in spell checking, so I can update them all. We can also add advices to the rejected word list.

@DemeSzabolcs
Copy link
Member Author

DemeSzabolcs commented Feb 15, 2023

Yeah, it might be overkill. I'm fine with addressing it in OSOE-523.

@0liver 0liver removed the good first issue Good for newcomers label Feb 15, 2023
@BenedekFarkas
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants