Upgrading to OC 1.0.0-rc2-16132 #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piedone
reviewed
Apr 22, 2021
There was a problem hiding this comment.
Thank you! Since we don't want to move the orchard-core-preview branch forward until the 1.0 release I won't merge this before that. Made a note for this under Lombiq/Orchard-Training-Demo-Module#47 though.
| <TargetFramework>netcoreapp3.1</TargetFramework> | ||
| <AddRazorSupportForMvc>true</AddRazorSupportForMvc> | ||
| <DefaultItemExcludes>$(DefaultItemExcludes);.git*;node_modules\**</DefaultItemExcludes> | ||
| <LangVersion>Latest</LangVersion> |
There was a problem hiding this comment.
This is better managed on a solution-level, please remove it.
Comment on lines
+3
to
+37
| <PropertyGroup> | ||
| <TargetFramework>netcoreapp3.1</TargetFramework> | ||
| <AddRazorSupportForMvc>true</AddRazorSupportForMvc> | ||
| <DefaultItemExcludes>$(DefaultItemExcludes);.git*;node_modules\**</DefaultItemExcludes> | ||
| <LangVersion>Latest</LangVersion> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Remove="node_modules\**" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <None Remove="node_modules\**" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <FrameworkReference Include="Microsoft.AspNetCore.App" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <FrameworkReference Include="Microsoft.AspNetCore.App" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="OrchardCore.Autoroute" Version="1.0.0-rc2-13929" /> | ||
| <PackageReference Include="OrchardCore.ContentManagement" Version="1.0.0-rc2-13929" /> | ||
| <PackageReference Include="OrchardCore.Contents" Version="1.0.0-rc2-13929" /> | ||
| <PackageReference Include="OrchardCore.DisplayManagement" Version="1.0.0-rc2-13929" /> | ||
| <PackageReference Include="OrchardCore.Flows" Version="1.0.0-rc2-13929" /> | ||
| <PackageReference Include="OrchardCore.Html" Version="1.0.0-rc2-13929" /> | ||
| <PackageReference Include="OrchardCore.MetaWeblog.Abstractions" Version="1.0.0-rc2-13929" /> | ||
| <PackageReference Include="OrchardCore.Module.Targets" Version="1.0.0-rc2-13929" /> | ||
| <PackageReference Include="OrchardCore.ResourceManagement" Version="1.0.0-rc2-13929" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="OrchardCore.Autoroute" Version="1.0.0-rc2-16132" /> | ||
| <PackageReference Include="OrchardCore.ContentManagement" Version="1.0.0-rc2-16132" /> | ||
| <PackageReference Include="OrchardCore.Contents" Version="1.0.0-rc2-16132" /> | ||
| <PackageReference Include="OrchardCore.DisplayManagement" Version="1.0.0-rc2-16132" /> | ||
| <PackageReference Include="OrchardCore.Flows" Version="1.0.0-rc2-16132" /> | ||
| <PackageReference Include="OrchardCore.Html" Version="1.0.0-rc2-16132" /> | ||
| <PackageReference Include="OrchardCore.MetaWeblog.Abstractions" Version="1.0.0-rc2-16132" /> | ||
| <PackageReference Include="OrchardCore.Module.Targets" Version="1.0.0-rc2-16132" /> | ||
| <PackageReference Include="OrchardCore.ResourceManagement" Version="1.0.0-rc2-16132" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference | ||
| Include="..\..\Libraries\Lombiq.HelpfulLibraries\Lombiq.HelpfulLibraries\Lombiq.HelpfulLibraries.csproj" | ||
| Condition="Exists('..\..\Libraries\Lombiq.HelpfulLibraries\Lombiq.HelpfulLibraries\Lombiq.HelpfulLibraries.csproj')" /> | ||
| <ProjectReference | ||
| Include="..\..\Libraries\Lombiq.HelpfulLibraries\Lombiq.HelpfulLibraries.csproj" | ||
| Condition="Exists('..\..\Libraries\Lombiq.HelpfulLibraries\Lombiq.HelpfulLibraries.csproj')" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ProjectReference | ||
| Include="..\..\Libraries\Lombiq.HelpfulLibraries\Lombiq.HelpfulLibraries\Lombiq.HelpfulLibraries.csproj" | ||
| Condition="Exists('..\..\Libraries\Lombiq.HelpfulLibraries\Lombiq.HelpfulLibraries\Lombiq.HelpfulLibraries.csproj')" /> | ||
| <ProjectReference | ||
| Include="..\..\Libraries\Lombiq.HelpfulLibraries\Lombiq.HelpfulLibraries.csproj" | ||
| Condition="Exists('..\..\Libraries\Lombiq.HelpfulLibraries\Lombiq.HelpfulLibraries.csproj')" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Please keep the indentation (the VS default).
12 tasks
|
Updated the module to 1.0. in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligning OC version with latest.