OSOE-653: Relative URL prefixed with /Admin in case of an admin controller action if [Route] attribute is used in Lombiq.HelpfulLibraries #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psichorex
approved these changes
Jul 12, 2023
jtkech
reviewed
Jul 12, 2023
| var prefix = _isAdminLazy.Value ? "/Admin/" : "/"; | ||
| var isAdminWithoutRoute = _isAdminLazy.Value && _action.GetCustomAttribute(typeof(RouteAttribute)) == null; | ||
|
|
||
| var prefix = isAdminWithoutRoute ? "/Admin/" : "/"; |
There was a problem hiding this comment.
I don't know the context but is it correct to use an hardcoded /Admin prefix, shouldn't it be retrieved from the current AdminOptions.AdminUrlPrefix?
There was a problem hiding this comment.
Thanks for pointing that out! I didn't change that since that was not the focus of the issue and I didn't want to mess around. But it's a good point, I can create an issue for that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-653
Fixes #201