Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Logo to Readme.md #5

Closed
wants to merge 12 commits into from
Closed

Added Logo to Readme.md #5

wants to merge 12 commits into from

Conversation

tjulises
Copy link

@tjulises tjulises commented Jun 5, 2018

No description provided.

@tjulises
Copy link
Author

tjulises commented Jun 5, 2018

Hey @Piedone ,

Here's the pull request, and here's the google drive link with its monochromatic version, color variation and sizes in .png, pdf, svg, cdr. All this for any future update!

Thanks for letting me a part of this project!
Best Regards.

@tjulises
Copy link
Author

tjulises commented Jun 5, 2018

If you could hand me a link when the logo has been updated @Piedone , that would be awesome!

@Piedone
Copy link
Member

Piedone commented Jun 5, 2018

Please add the files into the repository too. Also, don't you want to give yourself some credit? :) Please add some to the Readme (along the the lines of "The project's logo was created by ... you can reach him under..."

@tjulises
Copy link
Author

tjulises commented Jun 6, 2018

Done @Piedone ,
sorry for the delete spam.

@Piedone
Copy link
Member

Piedone commented Jun 6, 2018

I'd have two more things to ask if you'd be so kind :):

  1. Please put the logo files (and I mean the ones you've uploaded to Google Drive) into a folder called Logos in the repo. No need to keep the other variations we didn't decide on.
  2. Please embed the logo file from the repo in the Readme (it should still work, you don't need to put it on postimg.cc).

Thank you!

@tjulises
Copy link
Author

tjulises commented Jun 6, 2018

#6 @Piedone

@Piedone
Copy link
Member

Piedone commented Jun 6, 2018

It was easier in the end for me to just add these directly instead of applying some changes in your branch. So I'll close this PR but your logo is in the repo and in the Readme too.

Thank you again!

@Piedone Piedone closed this Jun 6, 2018
@tjulises
Copy link
Author

tjulises commented Jun 6, 2018

Great, would you let me know when the logo is oficially updated as the orchard logo @Piedone ?

@Piedone
Copy link
Member

Piedone commented Jun 6, 2018

If you open this repo you should see the new logo.

LombiqBot pushed a commit that referenced this pull request Jan 11, 2019
VSIX-22: Dependency Injector felokosítása az Orchard Core-ban gyakran használt dependency-k felismerésére

--HG--
branch : dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants