Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-751: Upgrade to Orchard Core 1.8 #156

Merged
merged 27 commits into from
Feb 21, 2024
Merged

OSOE-751: Upgrade to Orchard Core 1.8 #156

merged 27 commits into from
Feb 21, 2024

Conversation

Psichorex
Copy link
Contributor

@Psichorex Psichorex commented Jan 18, 2024 •
edited by jira bot
Loading

Psichorex and others added 7 commits January 29, 2024 14:07
@Psichorex
Using T.
b2b2df7
@Psichorex
Using better OS determination.
6a843e9
@Psichorex
Removing directive.
c00a1f1
@Psichorex
Merge remote-tracking branch 'origin/dev' into issue/OSOE-751
1cc60a6
@Psichorex
Revert "Addressing warnings."
e321e90 
This reverts commit f9c267b.

# Conflicts:
#	Lombiq.DataTables.Samples/Services/SampleIndexBasedDataTableDataProvider.cs
#	Lombiq.DataTables.Samples/Services/SampleJsonResultDataTableDataProvider.cs
#	Lombiq.DataTables/Liquid/ActionsLiquidFilter.cs
@Psichorex
Fix.
217414e
@Piedone
Clarifying suppression comments
ec0cb39
@Psichorex
Copy link
Contributor Author

Psichorex commented Feb 18, 2024 •
edited
Loading

Even on the latest dev with OC 1.7 if I am running the NuGet solution with its test recipe and I execute the Data Tables Sample recipe and I navigate to the HomePage the DataTables dropdown that the UI Test is trying to find is missing. I get a failing CI on OSOE-751 because of this and I don't know whether I am missing something here. So I know that using the BaseTheme.Samples recipe it's on the UI but this Nuget test recipe I have never tested this exact functionality. For me it seems to be missing. Both on dev both on my OC 1.8 branch. Well atleast the selector "//li[contains(@Class, 'dropdown') and contains(., 'Data Tables')]"` is cleary not in the DOM.
image

I am also unable to run tests locally due toOpenQA.Selenium.WebDriverException : Creating the web driver failed with the message "End of Central Directory record could not be found.". This can mean that there is a leftover web driver process that you have to kill manually.
I did a KillLeftoverProcesses but it didn't resolve anything.
Also found this on SO https://stackoverflow.com/questions/78001426/openqa-selenium-webdriverexception-creating-the-web-driver-failed-with-the-mess it's 3 days old an I am unable to execute tests for like 2 days now. We faced something similar before with the WebDriver.

@Psichorex
Copy link
Contributor Author

Seems like it needed a whole Atata package upgrade for the Selenium Exception to go away. Now I can re-release UITT with it's dependants.

Psichorex
Psichorex commented Feb 21, 2024
View reviewed changes
...iq.DataTables/Tests/Lombiq.DataTables.Tests.UI/Extensions/TestCaseUITestContextExtensions.cs Outdated
{
await context.SignInDirectlyAsync();
await context.ExecuteDataTablesSampleRecipeDirectlyAsync();

if (!isNugetTest)
if (!checkMainMenu)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negation should be removed here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes to this because now you have to set checkMainMenu to true if you don't want it to be checked.

@Psichorex Psichorex merged commit 2a48931 into dev Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piedone Piedone Piedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Psichorex @Piedone