OSOE-47: Open-source Data Tables #80

sarahelsaig · 2022-01-19T19:17:46Z

CHANGE BASE BRANCH TO DEV BEFORE MERGE.

This merges the release upgrade done in FINI-859. It might be worthwhile to review that PR first, but do as you please. :) This branch further upgrades from Orchard Core 1.0.0 to 1.2.1 but there were no issues with that.

…uditTrail.

This reverts commit fdb9ea7.

# Conflicts: # ResourceManagementOptionsConfiguration.cs

…ta-Tables into issue/FINI-859

# Conflicts: # ResourceManagementOptionsConfiguration.cs

(cherry picked from commit 6beca87)

(cherry picked from commit 0c56c67)

sarahelsaig · 2022-02-19T22:12:02Z

Lombiq.DataTables.Samples/Views/Sample/DataTableTagHelper.cshtml

+    @* Forces the CultureInfo to use the canonical date format. This prevents user or system level customizations. We
+       need this for the UI tests to work reliably. *@
+    var cultureInfo = new CultureInfo(CultureInfo.CurrentCulture.Name, useUserOverride: false);


I don't have the foggiest why this came up only now, so any insight is appreciated. I think it might be related to when you edit Time & Language > _Region> Change data format in the system Settings app, but I'm not super sure.

Isn't useUserOverride something that you can specify in the format string? Because then we can use the DateTime shape. If not, shouldn't this be added to the shape as well? Please open an OC issue.

Isn't useUserOverride something that you can specify in the format string?

No, you can only set IFormatProvider which defaults to CultureInfo.CurrentCulture which apparently can be affected by your system settings.

Because then we can use the DateTime shape. If not, shouldn't this be added to the shape as well? Please open an OC issue.

Does the shape even accept a format provider? I can't find a full documentation for that shape and it's tough to search for it in the OC source code becuase "DateTime" is kind of a common word.

It doesn't except a format provider but only a format string, see here.

Thanks. I think what they do is very reasonable, since OC is supposed to to set the current UI culture. Let me check if I can find something bug reportable on that end.

Generally I think the problem is with how OC sets the CurrentCulture/CurrentUICulture. I have made a bug report with a suggested solution here. I also have added this to the comment above.

They don't seem to be super receptive to it. However I have a fallback issue here.
Also I think it's a valid point that the server shouldn't customize the date format in the first place, so why is it in CI?

Replied there.

Lombiq.DataTables.Samples/Views/Sample/DataTableTagHelper.cshtml

Piedone · 2022-02-20T19:44:17Z

Lombiq.DataTables.Samples/Views/Sample/DataTableTagHelper.cshtml

+    @* Forces the CultureInfo to use the canonical date format. This prevents user or system level customizations. We
+       need this for the UI tests to work reliably. *@
+    var cultureInfo = new CultureInfo(CultureInfo.CurrentCulture.Name, useUserOverride: false);


Isn't useUserOverride something that you can specify in the format string? Because then we can use the DateTime shape. If not, shouldn't this be added to the shape as well? Please open an OC issue.

Lombiq.DataTables/Lombiq.DataTables.csproj

Lombiq.DataTables/Tests/Lombiq.DataTables.Tests.UI/Lombiq.DataTables.Tests.UI.csproj

Lombiq.DataTables/wwwroot/lombiq/icbin-datatable.js

Piedone

See comments.

Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>

Readme.md

Lombiq.DataTables/wwwroot/lombiq/icbin-datatable.js

Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>

Lombiq.DataTables/Tests/Lombiq.DataTables.Tests.UI/Readme.md

Lombiq.DataTables/Tests/Lombiq.DataTables.Tests.UI/Lombiq.DataTables.Tests.UI.csproj

Lombiq.DataTables/Lombiq.DataTables.csproj

Lombiq.DataTables.Samples/Lombiq.DataTables.Samples.csproj

Lombiq.DataTables.Samples/Readme.md

Piedone · 2022-02-21T14:25:52Z

Lombiq.DataTables.Samples/Views/Sample/DataTableTagHelper.cshtml

+    @* Forces the CultureInfo to use the canonical date format. This prevents user or system level customizations. We
+       need this for the UI tests to work reliably. *@
+    var cultureInfo = new CultureInfo(CultureInfo.CurrentCulture.Name, useUserOverride: false);


Replied there.

Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>

Lombiq.DataTables.Samples/Readme.md

sarahelsaig added 30 commits August 8, 2021 13:09

Update PackageReference versions.

6c2a89e

Use BeginTransactionAsync instead of DemandAsync.

5b5d8a6

Replace ResourceManifest.

1546d32

Prevent package downgrade.

1f2bdec

Fix remaining build issues.

72267a2

Fix tests.

22f9957

More test code fixes.

91ec04f

Fix liquid tests.

9746db1

Completely fork the incompatible OrchardCore.AuditTrail into Lombiq.A…

c657f3e

…uditTrail.

Bootstrap 5 compatibility (data-bs-toggle).

fdb9ea7

Rename to Finitive.AuditTrail.

ba28127

Revert "Bootstrap 5 compatibility (data-bs-toggle)."

09c86e6

This reverts commit fdb9ea7.

Merge remote-tracking branch 'origin/dev' into issue/FINI-859

dc7a243

Merge remote-tracking branch 'origin/dev' into issue/FINI-859

46eebb5

# Conflicts: # ResourceManagementOptionsConfiguration.cs

Fix zone usage.

144abf3

Merge branch 'issue/FINI-859' of https://github.com/Lombiq/Orchard-Da…

af700cf

…ta-Tables into issue/FINI-859

Get rid of TransactionSqlDialectFactory.For as it's no longer supported.

29afb80

Clean up and prevent setup errors.

913cad7

Merge branch 'issue/FIN-670' into issue/FINI-859

92731fb

# Conflicts: # ResourceManagementOptionsConfiguration.cs

Merge branch 'dev' into issue/FINI-859

880d0f7

Update for OC 1.0 style resource manifest.

f448e78

Use ResourceManagementOptionsConfigurationBase.

646f9c0

Fix breaking change in adding shape to zone.

6e2c221

Eliminate more confusing and ambiguous dynamic usage.

804a411

Code styling.

69d8f7c

Revert ResourceManagementOptionsConfigurationBase.

6acf62b

Merge remote-tracking branch 'origin/dev' into issue/FINI-859

f5200bb

Merge remote-tracking branch 'origin/issue/FINI-859' into issue/OSOE-47

a04d072

Add missing license file.

87e7afb

(cherry picked from commit 6beca87)

Remove unnecessary PackageReferences.

0e7c8ee

(cherry picked from commit 0c56c67)

sarahelsaig added 7 commits February 19, 2022 17:55

Maybe it's a "different" en-US? Can we force it?

28c9e13

Is it T's fault?

d0e949b

okay now I really don't know

7df5a21

More investigation.

7898c79

Magic.

1addbb7

Antimagick.

a77f5f3

Add comment about useUserOverride usage.

98fbc8b

sarahelsaig commented Feb 19, 2022

View reviewed changes

Piedone reviewed Feb 20, 2022

View reviewed changes

Piedone requested changes Feb 20, 2022

View reviewed changes

sarahelsaig and others added 7 commits February 20, 2022 22:08

Update Lombiq.DataTables.Samples/Views/Sample/DataTableTagHelper.cshtml

571a24c

Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>

Update various docs.

a06d9e1

Bugfix path & gitignore.

0e23d26

improve doc phrasing

b0a6d18

Update title according to naming convention,

468fc04

Make Lombiq.DataTables.Samples NuGet too.

490d118

Comments about bugs and troubles.

0848076

Piedone reviewed Feb 21, 2022

View reviewed changes

Readme.md Outdated Show resolved Hide resolved

Lombiq.DataTables/wwwroot/lombiq/icbin-datatable.js Show resolved Hide resolved

Update Readme.md

ffd1ab6

Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>

Piedone reviewed Feb 21, 2022

View reviewed changes

sarahelsaig and others added 4 commits February 21, 2022 15:52

Apply suggestions from code review

c4dcdfb

Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>

Remove OrchardCore.Liquid package reference.

6a1123b

Fix samples readme and package references.

19389bd

Fix reference.

d07dada

Piedone requested changes Feb 21, 2022

View reviewed changes

Lombiq.DataTables.Samples/Readme.md Outdated Show resolved Hide resolved

Fixing Samples Readme

0f97b78

Piedone changed the base branch from issue/OSOE-47-base to dev February 21, 2022 19:25

Piedone merged commit 21753ac into dev Feb 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OSOE-47: Open-source Data Tables #80

OSOE-47: Open-source Data Tables #80

sarahelsaig commented Jan 19, 2022 •

edited by Piedone

sarahelsaig Feb 19, 2022

Piedone Feb 20, 2022

sarahelsaig Feb 20, 2022 •

edited

Piedone Feb 20, 2022

sarahelsaig Feb 21, 2022 •

edited

sarahelsaig Feb 21, 2022

sarahelsaig Feb 21, 2022

Piedone Feb 21, 2022

Piedone Feb 20, 2022

Piedone left a comment

Piedone Feb 21, 2022

OSOE-47: Open-source Data Tables #80

OSOE-47: Open-source Data Tables #80

Conversation

sarahelsaig commented Jan 19, 2022 • edited by Piedone

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sarahelsaig Feb 20, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sarahelsaig Feb 21, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Piedone left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sarahelsaig commented Jan 19, 2022 •

edited by Piedone

sarahelsaig Feb 20, 2022 •

edited

sarahelsaig Feb 21, 2022 •

edited