Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unable to factorize 2804275833720261793 #220

Closed
andrew-ld opened this issue Feb 6, 2024 · 1 comment
Closed

unable to factorize 2804275833720261793 #220

andrew-ld opened this issue Feb 6, 2024 · 1 comment

Comments

@andrew-ld
Copy link

andrew-ld commented Feb 6, 2024 •
edited

when I do factorize 2804275833720261793 I get (1, 2804275833720261793), this is obviously wrong and cannot be accepted by the telegram backend.

madelineproto algorithm returns (1803100129, 1555252417) which is a valid pair accepted by the backend
@Lonami Lonami closed this as completed in f2ad7a3 Feb 6, 2024
@Lonami
Copy link
Owner

Lonami commented Feb 6, 2024

That's a fun one. Don't really know why a different set of "random" numbers fixes it but hey. I've tried to avoid making things divisible by 2 now.

@andrew-ld andrew-ld mentioned this issue Feb 9, 2024
Open
IMXEren added a commit to IMXEren/grammers that referenced this issue Feb 18, 2024
@IMXEren @Lonami
Upstream (#4)
777c980 
* Avoid panic when media is not downloadable (Lonami#219)

* Fix factorize could return 1

Closes Lonami#220.

* Make factorize function more resiliant

* Bump grammers-crypto to 0.6

* Fix other packages must use latest -crypto

---------

Co-authored-by: Lonami Exo <totufals@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lonami @andrew-ld