Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump grammers for fix factorization issue #31

Open
andrew-ld opened this issue Feb 9, 2024 · 3 comments
Open

bump grammers for fix factorization issue #31

andrew-ld opened this issue Feb 9, 2024 · 3 comments

Comments

@andrew-ld
Copy link

Lonami/grammers#220

@cher-nov cher-nov changed the title bump grammers for fix factoritazion issue bump grammers for fix factorization issue Feb 10, 2024
cher-nov added a commit that referenced this issue Feb 10, 2024
This addresses issue #31, I hope.
@cher-nov
Copy link
Owner

@andrew-ld Is it okay now?

@Lonami
Copy link
Collaborator

Lonami commented Feb 10, 2024

Right, totally forgot about the fact cryptg depends on grammers now.

I haven't released the fix yet as a new grammers version so I would wait a bit more before bumping the version here.

If we're doing this, I'm also not confident that my "fix" is enough, and would prefer to tweak it some more.

@Lonami
Copy link
Collaborator

Lonami commented Feb 10, 2024

Hm it's kind of annoying because I made some changes to do encryption in-place so cryptg will need to be adjusted to handle that even if I release the factorization fix. So this may take longer than I had hoped.

Or not, since the exported functions don't mutate it, nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants