Remove spongycastle #261
Closed
Remove spongycastle #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…done with a regex. Minor gradle tweaks
|
Closing, will think about keeping it, just strongly update code and documentation to prefer BC over SC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Songy Castle is old and hasn't been updated since 2017. There could be a risk for security issues using it, though I am no expert with the Castles to know how much integration is there just for a Cipher instance.
This was a legacy support Android API running lower than Honeycomb. Google has since renamed their BC package since(even though that is now deprecated too).
Using normal BouncyCastle for Android is recommended based on many discussions whille reseaching. Even android development has a support floor for API 21 (API 24 is starting to become the new floor too with some dependencies).
See: https://stackoverflow.com/a/66323575/13225929
This wiki page should be updated to reflect the current info from the main readme.
Checklist
Addtional: