Replace "Leave a Power Token" checkbox with radio buttons #702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #697
I decided to replace the checkbox with radio buttons to avoid regularly dialogs. They now behave the following way.
If
canLeavePowerToken()
returnsfalse
,this.leavePowerToken
is set tofalse
and causes the No radio to be preselected:If
canLeavePowerToken()
returnstrue
,this.leavePowerToken
is set toundefined
which forces the player to actively make a decision:If Confirm is clicked without a decision, an alert is shown, which seemed to be better to me than disabling Confirm: