Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI issues #89

Closed
3 tasks done
gereon77 opened this issue Jan 13, 2020 · 3 comments
Closed
3 tasks done

UI issues #89

gereon77 opened this issue Jan 13, 2020 · 3 comments
Labels
type:bug Something isn't working, a rule is not implemented correctly, ...

Comments

@gereon77
Copy link
Collaborator

gereon77 commented Jan 13, 2020

  • Sometimes hovering over the revealed wilding card in game log doesn't increase it but make it blinking. Screenshot doesn't make sense here. All other cards are increased.

  • CoK bid slider is weird when user has no PTs left. For position 0 it shows the previous bidden value and can't be moved. Was not able to test if it bids 4 or 0 then on confirm. Maybe this bid can be skipped as it is clear that user will bid nothing when he has no PTs
    image

  • Action Panel doesn't Update Westeros card after winter is coming
    image

@Longwelwind Longwelwind added the type:bug Something isn't working, a rule is not implemented correctly, ... label Jan 13, 2020
gereon77 pushed a commit to gereon77/swords-and-ravens that referenced this issue Jan 13, 2020
Longwelwind added a commit that referenced this issue Jan 13, 2020
add missing blanks and replace span with div for newlines. issue #89
@Longwelwind Longwelwind added this to the 2nd edition - Base game milestone Jan 15, 2020
@gereon77
Copy link
Collaborator Author

gereon77 commented Jan 24, 2020

Fixed issues:

  • Checkbox "Leave a Power Token" may be ticked even if it is disabled
    image

  • add warning dialog when not all regions are ordered

  • spelling mistake: Place an Power Token

  • Missing blank: Baratheon, holder of the Raven token, chose to[]trigger a Game of Thrones.

  • During CoK the track which is currently bid for is not updated. (it shows "players bid for iron throne track even though they are bidding for fiefdoms or kings court. everything is fine after page reload

  • missing log entry for "march area in *** removed"

  • when resolving a march order without moving a unit display a confirmation alert dialog.

  • warn before submitting unused muster points. By accident we both didnt use all our muster points. I just mustered from 1 castle instead of 3 because it seemed I have to submit the current area. In fact it finished my turn.

  • Missing blank[]; Greyjoy raided Lannister's Consolidate Power[]in Harrenhal from Riverrun

  • When splitting armies a new line should be added to the display of the performed moves

  • A blank space [] would improve readability: "Final order for *** track:[]" and here: "Houses bid for the ***[]track:[]"

  • Another missing blank []: "Martell attacked Tyrell from East Summer Sea[]to West Summer Sea with Ship, Ship."

  • Westeros card is not updated
    image

  • Decision buttons are placed incorrectly on page load. Zooming will place them correctly again
    image

  • Game did not proceed after "Valyrian steel blade" question. I decided "No" but then nothing happened. After reload "Waiting for next player" was shown and everything was fine again. Does not happen all the time.

  • Action panel is not updated after a performed raid.

  • Sometimes hovering over the revealed wilding card in game log doesn't increase it but make it blinking. Screenshot doesn't make sense here. All other cards are increased.

  • Action Panel is not updated after Valyrian steel blade usage.

@Longwelwind
Copy link
Owner

if ok i would delete the tracked by comment to not synchronize 2 locations

I didn't understand the proposition, sorry

I also plan to fix the bid slider issue.

Ok!

@Longwelwind
Copy link
Owner

Yeah, remove the tasks here that are already present in an other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working, a rule is not implemented correctly, ...
Projects
None yet
Development

No branches or pull requests

2 participants