Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Pod Pairing error message #121

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Conversation

marionbarker
Copy link
Collaborator

@marionbarker marionbarker commented Apr 13, 2024

This change modifies what is shown to the user in the situation where there is a Bluetooth error.

This particular error has caused several people (as reported on Facebook) to discard their pod and try again without realizing that toggling Bluetooth on the phone will probably solve the issue.

Note - this is an OmniBLE specific issue. The OmniKit messages do not need modification.

Test:

  • Use rPi to trigger the error (shown on left of graphic)
  • Build using this modification and trigger the same error (shown on right of graphic)

Edited to show new graphic from latest commit (35d5bcb).

omnible-pr-121-message-update-vs2

Copy link

@itsmojo itsmojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should to limit the use of possibleBluetoothIssue error to only underlying commsError cases and it should be independent of whether a pod was found

OmniBLE/PumpManagerUI/ViewModels/PairPodViewModel.swift Outdated Show resolved Hide resolved
OmniBLE/PumpManager/PodCommsSession.swift Outdated Show resolved Hide resolved
@marionbarker
Copy link
Collaborator Author

Modified the code to address the issues mentioned by @ps2 and updated the graphic to go with new code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants