New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Protocol3] Added circuit testing support + small improvements #396
Conversation
Let's assume one particular slot will be used by ID 1, 101, 201, .... 901... When we set the slot's current ID to 801 with some non-zero filed amount, does that guarantee that all orders (created or not) that have id=1, 101,...701 are considered canceled (fully matched)? It is also my understanding that the filled amount set shall never be 0, otherwise, it will clear all history data for order 1, 101, ... 701. |
There are So let's say an order gets partially filled with What was changed in this PR is that cancellations of orders only updated the |
This is something @hosschao and @lydy should take a look at. |
make
. All tests can be run withnpm run test-circuits
.fillB
. This should be more accurate and is cheaper.orderID
>tradingHistory.orderID
the filled amount is reset to 0. This accurately represent the filled amount of theorderID
stored in the trading history (but the order is cancelled, so it doesn't actually matter for the protocol).