Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding function to open a link in new tab in social section #38

Merged
merged 2 commits into from
Apr 26, 2024
Merged

adding function to open a link in new tab in social section #38

merged 2 commits into from
Apr 26, 2024

Conversation

pthoelken
Copy link
Contributor

PR from #37

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for hugo-theme-nightfall ready!

Name Link
🔨 Latest commit d764a13
🔍 Latest deploy log https://app.netlify.com/sites/hugo-theme-nightfall/deploys/662b3b059528d60009893580
😎 Deploy Preview https://deploy-preview-38--hugo-theme-nightfall.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pthoelken
Copy link
Contributor Author

I've also added aria-label function here d764a13

It's better for your SEO and any accessibility like page reader.

@LordMathis
Copy link
Owner

Thanks for the contribution

@LordMathis LordMathis merged commit 80e1b7f into LordMathis:main Apr 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants