-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Languages: add italian interaction models and add it to manifest #5
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
skill-package/skill.json
Outdated
} | ||
}, | ||
"testingInstructions": "In order to test this skill you need an Amazon Account with a phone number and a Telegram Messenger Account that is linked to that phone number.\n\nTo get a free phone number you can use:\nwww.textnow.com\nLogin: TODO\nPassword: TODO\n\nAdd this phone number to the Amazon testing account.\n\nCreate a Telegram Messenger account with you phone number:\n- Download the Telegram Messenger for your OS at: https://telegram.org/\n- At some point Telegram will sent you a code to your FreeNow number. Check your texts for that code.\n\nTest the skill\n- Alexa, open telegram connect\n- Couple Alexa with Telegram Messenger:\n Alexa will ask you for a code. Check you Telegram Messenger for that code.\n- After you successfully coupled Alexa with Telegram, you can say:\n Check my Telegrams\n Learn more about the skill" | ||
"testingInstructions": "Per testare questa skill avrai bisogno di un account Amazon con un numero di telefono collegato ed un account Telegram, collegato allo stesso numero.\n\nPer ottenere un numero di telefono gratuito, puoi usare:\nwww.textnow.com\nLogin: TODO\nPassword: TODO\n\nAggiungi questo numero al tuo account Amazon.\n\nCrea un account su Telegram con questo numero:\n- Scarica Telegram Messenger per il tuo sistema operativo qui: https://telegram.org/\n- Telegram invierà un codice al numero ottenuto con FreeNow. Controlla i messaggi.\n\nTesta la skill\n- Alexa, apri telegram connect\n- Integra Alexa con Telegram Messenger:\n Alexa ti chiederà di un codice. Controlla ti sia arrivato in Telegram.\n- Dopo aver integrato Alexa e Telegram con successo, potrai dire:\n Controlla i miei Telegram\n Informazioni su questa skill" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the testing instructions back to English. We send them only once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved by 6be6fb3
@@ -0,0 +1,143 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to have all Italian speech texts a file inside lambda/skill/i18n is needed as well. That would be amazing if you could add this as well. You can create a file similar to those that are already in the folder and add the Italian text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved by 3fdb2c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some small changes.
def __init__(self, timezone: tzinfo): | ||
self.timezone = timezone | ||
self.SKILL_NAME = 'Telegram Connect' | ||
self.SKILL_NAME_SPOKEN_IT = "<lang xml:lang='it-IT'>Telegram Connect</lang>".format(self.SKILL_NAME) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change that back to:
self.SKILL_NAME_SPOKEN_EN = "<lang xml:lang='en-US'>Telegram Connect</lang>".format(self.SKILL_NAME)
This specifies that Alexa will say 'Telegram Connect' in an English accent. If you want that Alexa says it in an Italian way you can just do something like:
self.SKILL_NAME_SPOKEN_EN = self.SKILL_NAME
However, in German she says it in a weird way so I forced her to pronounce it in English, since the skill name are English words. Addtitionally, self.SKILL_NAME_SPOKEN_EN
is used in different places that is way it wouldn't work if we change the name of the variable.
If you want, you can also update the testcase inside lambda/skill_test/test_language_mode.py. This test checks whether all the defined LanguageModel
s have the same amount of attributes and the names of attributes must all be identical.
# GeneralStuff | ||
############################## | ||
self.ACKS = ["Okay", "Va bene", "Okaaay"] | ||
self.ACCEPTANCE_ACKS = ["Okay", "Sicuro", "Va bene", "Ricevuto", "You got it"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove all English words like: You got it
.
############################## | ||
self.ACKS = ["Okay", "Va bene", "Okaaay"] | ||
self.ACCEPTANCE_ACKS = ["Okay", "Sicuro", "Va bene", "Ricevuto", "You got it"] | ||
self.DONE_ACKS = ["Okay", "Va bene", "Ricevuto", "Fatto", "You got it"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
self.NO_NEW_TELEGRAMS = "Non hai nuovi messaggi telegram" | ||
self.NEW_TELEGRAMS = 'Hai nuovi messaggi telegram. Vuoi ascoltarli?' | ||
self.NEW_SETUP = 'Benvenuto a {}. {} integra Alexa con Telegram ' \ | ||
'Messenger. Sei pronto alla configurazione?'.format(self.SKILL_NAME_SPOKEN_IT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh ok, I see that you changed it here as well. But as mentioned above: If you want that Alexa pronounces it with Italian accent you could just use self.SKILL_NAME
.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.