Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task 233 content assist should not propose ambiguous elements #235

Merged
merged 14 commits into from Jul 30, 2020
Merged

Task 233 content assist should not propose ambiguous elements #235

merged 14 commits into from Jul 30, 2020

Conversation

LorenzoBettini
Copy link
Owner

@LorenzoBettini LorenzoBettini commented Jul 30, 2020 •
edited

Closes #233

@LorenzoBettini
233: pass the IScope directly
bc8db61 
Task-Url: http://github.com/LorenzoBettini/edelta/issues/233
@LorenzoBettini
233: use also the qualified name in content assist
3d78790 
Task-Url: http://github.com/LorenzoBettini/edelta/issues/233
@LorenzoBettini
shortened target platform
4376d72
@LorenzoBettini
233: intercept and modify the configurable proposal
209cbd2 
Task-Url: http://github.com/LorenzoBettini/edelta/issues/233
@LorenzoBettini
233: intercept and modify the configurable proposal with filter
748b17a 
Task-Url: http://github.com/LorenzoBettini/edelta/issues/233
@LorenzoBettini
233: simplified
e105054 
Task-Url: http://github.com/LorenzoBettini/edelta/issues/233
@LorenzoBettini
233: added content assist tests
c96aec2 
Task-Url: http://github.com/LorenzoBettini/edelta/issues/233
@LorenzoBettini
233: extracted EdeltaOverriddenPrefixMatcher
00a1768 
Task-Url: http://github.com/LorenzoBettini/edelta/issues/233
@LorenzoBettini
233: documented test
24dff82 
Task-Url: http://github.com/LorenzoBettini/edelta/issues/233
@LorenzoBettini
233: additional content assist test
e54e1ad 
Task-Url: http://github.com/LorenzoBettini/edelta/issues/233
@LorenzoBettini
233: improved example
25f0911 
Task-Url: http://github.com/LorenzoBettini/edelta/issues/233
@LorenzoBettini
233: fixed javadoc
d5a8d38 
Task-Url: http://github.com/LorenzoBettini/edelta/issues/233
@LorenzoBettini
233: documented EdeltaProposalProvider
73104f0 
Task-Url: http://github.com/LorenzoBettini/edelta/issues/233
@LorenzoBettini
233: count instead of creating a list
b16db13 
Task-Url: http://github.com/LorenzoBettini/edelta/issues/233
@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@coveralls
Copy link

coveralls commented Jul 30, 2020 •
edited

Pull Request Test Coverage Report for Build 1459

  • 47 of 47 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1446: 0.0%
Covered Lines: 1915
Relevant Lines: 1915
💛 - Coveralls

@LorenzoBettini LorenzoBettini merged commit 5a85719 into master Jul 30, 2020
@LorenzoBettini LorenzoBettini deleted the task_233-Content_Assist_should_not_propose_ambiguous_elements branch July 30, 2020 16:49
@LorenzoBettini LorenzoBettini mentioned this pull request Jul 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content Assist should not propose ambiguous elements
2 participants
@LorenzoBettini @coveralls