forked from eclipse/xtext
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
JvmGenericTypeValidator with cycle in hierarchy
- Loading branch information
1 parent
2b19d66
commit 7c9717b
Showing
5 changed files
with
99 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 91 additions & 0 deletions
91
org.eclipse.xtext.xbase/src/org/eclipse/xtext/xbase/validation/JvmGenericTypeValidator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| /******************************************************************************* | ||
| * Copyright (c) 2023 itemis AG (http://www.itemis.eu) and others. | ||
| * This program and the accompanying materials are made available under the | ||
| * terms of the Eclipse Public License 2.0 which is available at | ||
| * http://www.eclipse.org/legal/epl-2.0. | ||
| * | ||
| * SPDX-License-Identifier: EPL-2.0 | ||
| *******************************************************************************/ | ||
| package org.eclipse.xtext.xbase.validation; | ||
|
|
||
| import static org.eclipse.xtext.util.Strings.*; | ||
| import static org.eclipse.xtext.xbase.validation.IssueCodes.*; | ||
|
|
||
| import java.util.HashSet; | ||
| import java.util.Set; | ||
|
|
||
| import org.eclipse.emf.ecore.EObject; | ||
| import org.eclipse.emf.ecore.EStructuralFeature; | ||
| import org.eclipse.xtext.common.types.JvmDeclaredType; | ||
| import org.eclipse.xtext.common.types.JvmGenericType; | ||
| import org.eclipse.xtext.common.types.JvmTypeReference; | ||
| import org.eclipse.xtext.validation.AbstractDeclarativeValidator; | ||
| import org.eclipse.xtext.validation.Check; | ||
| import org.eclipse.xtext.validation.EValidatorRegistrar; | ||
| import org.eclipse.xtext.xbase.jvmmodel.IJvmModelAssociations; | ||
|
|
||
| import com.google.inject.Inject; | ||
|
|
||
| /** | ||
| * @author Lorenzo Bettini - Initial contribution and API | ||
| * @author Sebastian Zarnekow - Author of the original Java code in XtendValidator extracted here. | ||
| */ | ||
| public class JvmGenericTypeValidator extends AbstractDeclarativeValidator { | ||
| @Inject | ||
| private IJvmModelAssociations associations; | ||
|
|
||
| @Override | ||
| public void register(EValidatorRegistrar registrar) { | ||
| // library validator is not registered for a specific language | ||
| } | ||
|
|
||
| @Check | ||
| public void interceptRoot(EObject o) { | ||
| var contents = o.eResource().getContents(); | ||
| if (contents.get(0) != o) | ||
| return; | ||
| contents.stream() | ||
| .filter(e -> !associations.getSourceElements(e).isEmpty()) | ||
| .filter(JvmGenericType.class::isInstance) | ||
| .map(JvmGenericType.class::cast) | ||
| .forEach(this::checkJvmGenericType); | ||
| } | ||
|
|
||
| protected void checkJvmGenericType(JvmGenericType type) { | ||
| checkSuperTypes(type); | ||
| } | ||
|
|
||
| protected void checkSuperTypes(JvmGenericType type) { | ||
| var primarySourceElement = associations.getPrimarySourceElement(type); | ||
| if (primarySourceElement != null && hasCycleInHierarchy(type, new HashSet<>())) { | ||
| error("The inheritance hierarchy of " + notNull(type.getSimpleName()) + " contains cycles", | ||
| primarySourceElement, | ||
| getFeatureForIssue(primarySourceElement), CYCLIC_INHERITANCE); | ||
| } | ||
| } | ||
|
|
||
| private boolean hasCycleInHierarchy(JvmGenericType type, Set<JvmGenericType> processedSuperTypes) { | ||
| JvmDeclaredType container = type; | ||
| do { | ||
| if (processedSuperTypes.contains(container)) | ||
| return true; | ||
| container = container.getDeclaringType(); | ||
| } while (container != null); | ||
| processedSuperTypes.add(type); | ||
| for (JvmTypeReference superTypeRef : type.getSuperTypes()) { | ||
| if (superTypeRef.getType() instanceof JvmGenericType) { | ||
| if (hasCycleInHierarchy((JvmGenericType) superTypeRef.getType(), processedSuperTypes)) | ||
| return true; | ||
| } | ||
| } | ||
| processedSuperTypes.remove(type); | ||
| return false; | ||
| } | ||
|
|
||
| /** | ||
| * The default implementation returns the feature "name". | ||
| */ | ||
| protected EStructuralFeature getFeatureForIssue(EObject object) { | ||
| return object.eClass().getEStructuralFeature("name"); | ||
| } | ||
| } |