Feature Show Reminder before answer (ankitects#3064)

In the deck config you can choose to show a reminder instead of showing
directly the answer at the end of the autoupdate time.

ftl/core/deck-config.ftl

@@ -448,10 +448,10 @@ deck-config-answer-hard = Answer Hard
 deck-config-answer-good = Answer Good
 deck-config-days-to-simulate = Days to simulate
 deck-config-desired-retention-below-optimal = Your desired retention is below optimal. Increasing it is recommended.
-deck-config-after-question-show-answer = Show answer
-deck-config-after-question-show-reminder = Show reminder
-deck-config-after-question = After question 
-deck-config-after-question-tool-tip = The action to perform after the end of the time of the question. Either show answer and auto update or just show a reminder.
+deck-config-question-action-show-answer = Show Answer
+deck-config-question-action-show-reminder = Show Reminder
+deck-config-question-action = Question action 
+deck-config-question-action-tool-tip = The action to perform after the end of the time of the question. Either show answer and auto update or just show a reminder.
 ## NO NEED TO TRANSLATE. This text is no longer used by Anki, and will be removed in the future.
 
 deck-config-bury-siblings = Bury siblings

proto/anki/deck_config.proto

@@ -101,9 +101,9 @@ message DeckConfig {
       ANSWER_ACTION_SHOW_REMINDER = 4;
     }
 
-    enum AfterQuestion{
-      AFTER_QUESTION_SHOW_ANSWER = 0;
-      AFTER_QUESTION_SHOW_REMINDER = 1 ;
+    enum QuestionAction{
+      QUESTION_ACTION_SHOW_ANSWER = 0;
+      QUESTION_ACTION_SHOW_REMINDER = 1 ;
     }
 
     repeated float learn_steps = 1;
@@ -145,7 +145,7 @@ message DeckConfig {
     bool disable_autoplay = 23;
     uint32 cap_answer_time_to_secs = 24;
     bool show_timer = 25;
-    AfterQuestion after_question = 36;
+    QuestionAction question_action = 36;
     bool stop_timer_on_answer = 38;
     float seconds_to_show_question = 41;
     float seconds_to_show_answer = 42;

qt/aqt/reviewer.py

@@ -136,7 +136,7 @@ class AnswerAction(Enum):
     ANSWER_HARD = 3
     SHOW_REMINDER = 4
 
-class AfterQuestion(Enum): 
+class QuestionAction(Enum): 
     SHOW_ANSWER = 0
     SHOW_REMINDER = 1
 
@@ -428,11 +428,11 @@ def _on_show_answer_timeout(self) -> None:
             self.auto_advance_enabled = False
             return
         try : 
-            after_question = list(AfterQuestion)[conf["afterQuestion"]]
+            question_action = list(QuestionAction)[conf["questionAction"]]
         except IndexError:
-            after_question = AfterQuestion.SHOW_ANSWER
+            question_action = QuestionAction.SHOW_ANSWER
 
-        if after_question == AfterQuestion.SHOW_ANSWER:
+        if question_action == QuestionAction.SHOW_ANSWER:
             self._showAnswer()
         else : 
             tooltip(tr.studying_question_time_elapsed())

rslib/src/deckconfig/mod.rs

@@ -13,7 +13,7 @@ pub use anki_proto::deck_config::deck_config::config::NewCardInsertOrder;
 pub use anki_proto::deck_config::deck_config::config::NewCardSortOrder;
 pub use anki_proto::deck_config::deck_config::config::ReviewCardOrder;
 pub use anki_proto::deck_config::deck_config::config::ReviewMix;
-pub use anki_proto::deck_config::deck_config::config::AfterQuestion;
+pub use anki_proto::deck_config::deck_config::config::QuestionAction;
 pub use anki_proto::deck_config::deck_config::Config as DeckConfigInner;
 pub use schema11::DeckConfSchema11;
 pub use schema11::NewCardOrderSchema11;
@@ -68,7 +68,7 @@ const DEFAULT_DECK_CONFIG_INNER: DeckConfigInner = DeckConfigInner {
     seconds_to_show_question: 0.0,
     seconds_to_show_answer: 0.0,
     answer_action: AnswerAction::BuryCard as i32,
-    after_question: AfterQuestion::ShowAnswer as i32,
+    question_action: QuestionAction::ShowAnswer as i32,
     wait_for_audio: true,
     skip_question_when_replaying_answer: false,
     bury_new: false,

rslib/src/deckconfig/schema11.rs

@@ -84,7 +84,7 @@ pub struct DeckConfSchema11 {
     #[serde(default)]
     answer_action: AnswerAction,
     #[serde(default)]
-    after_question: AfterQuestion,
+    question_action: QuestionAction,
     #[serde(default = "wait_for_audio_default")]
     wait_for_audio: bool,
     #[serde(default)]
@@ -112,7 +112,7 @@ pub enum AnswerAction {
 #[derive(Serialize_repr, Deserialize_repr, Debug, PartialEq, Eq, Clone)]
 #[repr(u8)]
 #[derive(Default)]
-pub enum AfterQuestion {
+pub enum QuestionAction {
     #[default]
     ShowAnswer = 0,
     ShowReminder = 1,
@@ -290,7 +290,7 @@ impl Default for DeckConfSchema11 {
             seconds_to_show_question: 0.0,
             seconds_to_show_answer: 0.0,
             answer_action: AnswerAction::BuryCard,
-            after_question: AfterQuestion::ShowAnswer,
+            question_action: QuestionAction::ShowAnswer,
             wait_for_audio: true,
             replayq: true,
             dynamic: false,
@@ -377,7 +377,7 @@ impl From<DeckConfSchema11> for DeckConfig {
                 stop_timer_on_answer: c.stop_timer_on_answer,
                 seconds_to_show_question: c.seconds_to_show_question,
                 seconds_to_show_answer: c.seconds_to_show_answer,
-                after_question: c.after_question as i32,
+                question_action: c.question_action as i32,
                 answer_action: c.answer_action as i32,
                 wait_for_audio: c.wait_for_audio,
                 skip_question_when_replaying_answer: !c.replayq,
@@ -444,9 +444,9 @@ impl From<DeckConfig> for DeckConfSchema11 {
                 4 => AnswerAction::ShowReminder,
                 _ => AnswerAction::BuryCard,
             },
-            after_question: match i.after_question {
-                1 => AfterQuestion::ShowReminder,
-                _ => AfterQuestion::ShowAnswer,
+            question_action: match i.question_action {
+                1 => QuestionAction::ShowReminder,
+                _ => QuestionAction::ShowAnswer,
             },
             wait_for_audio: i.wait_for_audio,
             replayq: !i.skip_question_when_replaying_answer,
@@ -526,7 +526,7 @@ static RESERVED_DECKCONF_KEYS: Set<&'static str> = phf_set! {
     "stopTimerOnAnswer",
     "secondsToShowQuestion",
     "secondsToShowAnswer",
-    "afterQuestion",
+    "questionAction",
     "answerAction",
     "waitForAudio",
     "sm2Retention",

ts/routes/deck-options/AutoAdvance.svelte

@@ -17,7 +17,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     import TitledContainer from "$lib/components/TitledContainer.svelte";
     import type { HelpItem } from "$lib/components/types";
 
-    import { answerChoices, afterQuestionChoices } from "./choices";
+    import { answerChoices, questionActionChoices } from "./choices";
     import type { DeckOptionsState } from "./lib";
     import SpinBoxFloatRow from "./SpinBoxFloatRow.svelte";
 
@@ -44,9 +44,9 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
             title: tr.deckConfigAnswerAction(),
             help: tr.deckConfigAnswerActionTooltip(),
         },
-        afterQuestion : {
-            title: tr.deckConfigAfterQuestion(),
-            help: tr.deckConfigAfterQuestionToolTip(),
+        questionAction : {
+            title: tr.deckConfigQuestionAction(),
+            help: tr.deckConfigQuestionActionToolTip(),
         },
     };
     const helpSections = Object.values(settings) as HelpItem[];
@@ -136,15 +136,15 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
         </Item>
         <Item>
             <EnumSelectorRow
-                bind:value={$config.afterQuestion}
-                defaultValue={defaults.afterQuestion}
-                choices={afterQuestionChoices()}
+                bind:value={$config.questionAction}
+                defaultValue={defaults.questionAction}
+                choices={questionActionChoices()}
             >
             <SettingTitle
                     on:click={() =>
-                        openHelpModal(Object.keys(settings).indexOf("afterQuestion"))}
+                        openHelpModal(Object.keys(settings).indexOf("questionAction"))}
                 >
-                    {settings.afterQuestion.title}
+                    {settings.questionAction.title}
             </SettingTitle>
             </EnumSelectorRow>
         </Item>

ts/routes/deck-options/choices.ts

@@ -10,7 +10,7 @@ import {
     DeckConfig_Config_NewCardSortOrder,
     DeckConfig_Config_ReviewCardOrder,
     DeckConfig_Config_ReviewMix,
-    DeckConfig_Config_AfterQuestion,
+    DeckConfig_Config_QuestionAction,
 } from "@generated/anki/deck_config_pb";
 import * as tr from "@generated/ftl";
 
@@ -187,15 +187,15 @@ export function answerChoices(): Choice<DeckConfig_Config_AnswerAction>[] {
     ];
 }
 
-export function afterQuestionChoices(): Choice<DeckConfig_Config_AfterQuestion>[] {
+export function questionActionChoices(): Choice<DeckConfig_Config_QuestionAction>[] {
     return [
         {
-            label: tr.deckConfigAfterQuestionShowAnswer(),
-            value: DeckConfig_Config_AfterQuestion.SHOW_ANSWER,
+            label: tr.deckConfigQuestionActionShowAnswer(),
+            value: DeckConfig_Config_QuestionAction.SHOW_ANSWER,
         },
         {
-            label: tr.deckConfigAfterQuestionShowReminder(),
-            value: DeckConfig_Config_AfterQuestion.SHOW_REMINDER,
+            label: tr.deckConfigQuestionActionShowReminder(),
+            value: DeckConfig_Config_QuestionAction.SHOW_REMINDER,
         },
     ];
 }