Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to show reminder instead of revealing answer #3064

Open
dae opened this issue Mar 10, 2024 · 10 comments
Open

Option to show reminder instead of revealing answer #3064

dae opened this issue Mar 10, 2024 · 10 comments

Comments

@dae
Copy link
Member

dae commented Mar 10, 2024

Problem
when studying cards with auto advance feature enabled, it suddenly flip the card after the selected time in the settings, this (sudden flip) is actually annoying, because sometime I’m still reading the card and it flips suddenly.

Originally reported on https://forums.ankiweb.net/t/request-auto-alert-feature-in-auto-advance-mode/42198

I'm imagining a drop-down option like: "After showing question: [reveal answer|show reminder]"

@escribapetrus
Copy link
Contributor

escribapetrus commented Mar 14, 2024

I'm planning to do this next. If someone's working on it or has a solution planned, please leave a comment. 🐐 🍄

UUPDATE: I haven't found the time yet to implement this. It's on my radar, but if anyone wants to do it, be my guest.

@Loudwig
Copy link
Contributor

Loudwig commented Apr 1, 2024

Hello, @escribapetrus are you still working on it ? I would like to give it a try to. Is it ok with you @dae also ? Thanks

@dae
Copy link
Member Author

dae commented Apr 1, 2024

No objections from me. When implementing it, please use an enum to store the drop-down option, so we can add more options in the future if we need to.

@escribapetrus
Copy link
Contributor

@Loudwig please go for it. I'm feeling sick today, and have no energy to do this.

@Loudwig
Copy link
Contributor

Loudwig commented Apr 3, 2024

Anki_Time_Extend_Auto_Update_video480p.mov.zip
Here is what I implemented, tell me what you think about it. Does it correspond to what you expected ? @dae @escribapetrus

@dae
Copy link
Member Author

dae commented Apr 4, 2024

Unfortunately it's a bit different. Currently, if the user sets a timer on the question side, it shows the answer. The desired feature here is a dropdown choice, so that instead of revealing the answer, Anki would show a pop-up (tooltip) message, like it does when the answer action is "show reminder". There is no need for a button to extend the timer.

@Loudwig
Copy link
Contributor

Loudwig commented Apr 4, 2024

Ah ! Ok i understand the feature now. I'll do it. It will be faster since i already looked at this part of the code. @dae
But isn't it weird not to have an autoupdate of the question if we are in a autoupdate mode ?
I keep the version with the button to extend the timer if you want to implement it. I think it could also be a solution to deal with original issue.

Loudwig added a commit to Loudwig/anki that referenced this issue Apr 4, 2024
This feature allow the user(if activate in the deck config) to have a
opportunity to increase the time before the auto-update of the
question/answer. At half of the auto-update time a button appears and if
clicked more time is added before the auto update of the
question/answer.
@Loudwig
Copy link
Contributor

Loudwig commented Apr 4, 2024

Here is the new feature !! Is it what you were thinking about ? @dae

Loudwig added a commit to Loudwig/anki that referenced this issue Apr 4, 2024
In the deck config you can choose to show a reminder instead of showing
directly the answer at the end of the autoupdate time.
@dae
Copy link
Member Author

dae commented Apr 5, 2024

Thank you, that's close. Could you submit a PR to this repo so I can add some comments to the code? There are a few minor things that need tweaking, like using "Title Case" for the options to match the capitalization of the other options, and a few tweaks to the wording of the docs.

@Loudwig
Copy link
Contributor

Loudwig commented Apr 5, 2024

Yes sure ! I did a PR but it failed merging with the main i believe.. ! Do i need to merge it with main on my own repository before doing a PR ? @dae

Loudwig added a commit to Loudwig/anki that referenced this issue Apr 8, 2024
In the deck config you can choose to show a reminder instead of showing
directly the answer at the end of the autoupdate time.
Loudwig added a commit to Loudwig/anki that referenced this issue Apr 10, 2024
Modification of the place of deck-config-question-action before
deck-config-answer-action for clarity. Supressing one sentence of
question-action-tool-tip for more clarity and brievty.
Loudwig added a commit to Loudwig/anki that referenced this issue Apr 12, 2024
Added a option in the deck config that allow the user to choose in
Autoupdate mode between showing a reminder or revealing the card.
Also added my name to the contributors
dae pushed a commit that referenced this issue Apr 13, 2024
* Feature Question Action Show Reminder (#3064)

Added a option in the deck config that allow the user to choose in
Autoupdate mode between showing a reminder or revealing the card.
Also added my name to the contributors

* Update ftl/core/deck-config.ftl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants