Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample wanted for coil-kt/coil #52

Open
jmfayard opened this issue Oct 8, 2020 · 16 comments · May be fixed by #117
Open

Sample wanted for coil-kt/coil #52

jmfayard opened this issue Oct 8, 2020 · 16 comments · May be fixed by #117
Assignees
Labels
android Android Sample good first issue Good for newcomers hacktoberfest

Comments

@jmfayard
Copy link
Collaborator

jmfayard commented Oct 8, 2020

About the library

What the sample could do

Show how to load image with coil and apply some basic transformation to it

Wants to contribute the sample?

This issue is blocked by Kickstart a project kotlin-android #50

But it can already be assigned to if you feel like working on this library once we the kotlin-android project is started.

So if you are interested, say so in a comment here!

@jmfayard jmfayard added good first issue Good for newcomers hacktoberfest android Android Sample labels Oct 8, 2020
@static-var
Copy link

I would love to write a sample for coil library.

@lizarragadev
Copy link

I'm interested in contributing 👍

@jmfayard
Copy link
Collaborator Author

Gustavo, would you like to work on this issue? @lizarragadev

@priyanka0906
Copy link

@jmfayard May I work on this.

@jmfayard
Copy link
Collaborator Author

Yes!

@priyanka0906
Copy link

Yes!

@jmfayard Thank you 😀

@priyanka0906
Copy link

@jmfayard there is no android option so that we can run the app.
where to add this sample? Can I make a separate repo for this aswell.

@jmfayard
Copy link
Collaborator Author

I'm not sure what you mean by "no android option"

kotlin-libraries-playground_–_versions_properties__kotlin-libraries-playground__and_Sample_wanted_for_coil-kt_coil_·_Issue__52_·_LouisCAD_kotlin-libraries-playground_and_Slack___feed___kotlinlang

Please put the code inside the android module.

The idea is that the first view would be a recycler-view or equivalent like this:

Android Samples

  • Contour
  • Coil

When you click on Contour, it would open the Contour view, when you click on Coil the Coil view

@priyanka0906
Copy link

priyanka0906 commented May 27, 2021

Screenshot (82)
@jmfayard There is no option showing to run the app

@LouisCAD
Copy link
Owner

LouisCAD commented May 27, 2021

Is there a MainActivity with the right intent filter in the project? Has Gradle sync been done?

@priyanka0906
Copy link

@LouisCAD Gradle has not been synced😅, its working now.
Thank you😀

@visheshjindal
Copy link

Hello @jmfayard

I would love to contribute to coil library sample.

@thesohelshaikh
Copy link

Hello @jmfayard Can I take this?

Few questions:

  • What kind of UI are you expecting? Just load an image or something else?
  • Is it necessary to use compose as UI system? I noticed coil fragment is using View system.

@Rishavgupta12345
Copy link

this is my first contributin can you please guide me what to do here :)

@amaan118921
Copy link

hey if this is not fixed for too long, i would love to take it up, so please assign me this issue.

@jmfayard
Copy link
Collaborator Author

jmfayard commented Oct 2, 2022

@amaan118921 sure thing, done, thanks for your contribution!

@amaan118921 amaan118921 linked a pull request Oct 4, 2022 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android Sample good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants