Skip to content

Commit

Permalink
Optimized Daly driver
Browse files Browse the repository at this point in the history
  • Loading branch information
mr-manuel committed May 23, 2023
2 parents bb93ee3 + a0a5ebf commit 5aa6163
Show file tree
Hide file tree
Showing 6 changed files with 167 additions and 263 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
* Added: JKBMS BLE - Show if balancing is active and which cells are balancing by @mr-manuel
* Added: JKBMS BLE - Show serial number and "User Private Data" field that can be set in the JKBMS App to identify the BMS in a multi battery environment by @mr-manuel
* Added: JKBMS BLE driver by @baranator
* Added: LLT/JBD BMS BLE driver by @idstein
* Added: Possibility to add `config.ini` to the root of a USB flash drive on install via the USB method by @mr-manuel
* Added: Possibility to configure a `VOLTAGE_DROP` voltage, if you are using a SmartShunt as battery monitor as there is a little voltage difference https://github.com/Louisvdw/dbus-serialbattery/discussions/632 by @mr-manuel
* Added: Post install notes by @mr-manuel
Expand All @@ -61,6 +62,7 @@
* Changed: Bash output by @mr-manuel
* Changed: Daly BMS - Fixed BMS alerts by @mr-manuel
* Changed: Daly BMS - Improved driver stability by @transistorgit & @mr-manuel
* Changed: Daly BMS - Reworked serial parser by @transistorgit
* Changed: Default config file by @ppuetsch
* Added missing descriptions to make it much clearer to understand by @mr-manuel
* Changed name from `default_config.ini` to `config.default.ini` https://github.com/Louisvdw/dbus-serialbattery/pull/412#issuecomment-1434287942 by @mr-manuel
Expand Down
3 changes: 1 addition & 2 deletions etc/dbus-serialbattery/battery.py
Original file line number Diff line number Diff line change
Expand Up @@ -263,12 +263,11 @@ def manage_charge_voltage_linear(self) -> None:
voltageSum - penaltySum,
utils.MIN_CELL_VOLTAGE * self.cell_count,
),
utils.MAX_CELL_VOLTAGE * self.cell_count
utils.MAX_CELL_VOLTAGE * self.cell_count,
),
3,
)


self.charge_mode = (
"Bulk dynamic"
# + " (vS: "
Expand Down
5 changes: 3 additions & 2 deletions etc/dbus-serialbattery/bms/battery_template.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
# -*- coding: utf-8 -*-

# NOTES
# Please also update the feature comparison table, if you are adding a new BMS
# https://louisvdw.github.io/dbus-serialbattery/general/features/#bms-feature-comparison
# Please see "Add/Request a new BMS" https://louisvdw.github.io/dbus-serialbattery/general/supported-bms#add-by-opening-a-pull-request
# in the documentation for a checklist what you have to do, when adding a new BMS

# avoid importing wildcards
from battery import Protection, Battery, Cell
from utils import is_bit_set, read_serial_data, logger
import utils
Expand Down
Loading

0 comments on commit 5aa6163

Please sign in to comment.