Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Renogy.unique_identifier method to allow multiple batteries #1017

Merged
merged 1 commit into from Mar 22, 2024

Conversation

sstoops
Copy link
Contributor

@sstoops sstoops commented Mar 21, 2024

After running into an issue with multiple Renogy batteries conflicting due to the Renogy class not having a unique_identifier method, thus, dropping back to hardware version, I've added this method to return the battery's serial number. This has allowed me to connect multiple nearly-identical batteries.

Copy link
Collaborator

@mr-manuel mr-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mr-manuel
Copy link
Collaborator

Thanks for helping to improve the driver.

@mr-manuel mr-manuel merged commit 50d7595 into Louisvdw:master Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants