Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for EG4-LL 12v BMS #1026

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

tuxntoast
Copy link

@tuxntoast tuxntoast commented Mar 29, 2024

Adding a driver for EG4-LL 12v BMS.

  • Add your battery class and battery class import in alphabetical order in the etc/dbus-serialbattery/dbus-serialbattery.py
  • Add your BMS to the BMS feature comparison page by editing docs/docs/general/features.md
  • Add your BMS to the Supported BMS page by editing docs/docs/general/supported-bms.md
  • Do not import wildcards *
  • If available populate self.max_battery_charge_current and self.max_battery_discharge_current with values read from the BMS
  • If available populate self.unique_identifier with a unique value to distinguish the BMS in a multiple battery setup
  • If your BMS don't run with the default settings add installation notes to the How to install, update, disable, enable and uninstall docs/docs/general/install.md
  • If your BMS needs custom settings that the user should be able to change, add it below the ; --------- BMS specific settings --------- section in the etc/dbus-serialbattery/config.default.ini
  • Make sure the GitHub Actions run fine in your repository. In order to make the GitHub Actions run please select in your repository settings under Actions -> General -> Actions permissions the option Allow all actions and reusable workflows. Check also in your repository settings under Actions -> General -> Workflow permissions if Read and write permissions are selected. After this changes you have to make a new commit, if you don't see any Actions run. This will check your code for Flake8 and Black Lint errors. Here is a short instruction on how to set up Flake8 and Black Lint checks in VS Code. This will save you a lot of time.

@mr-manuel
Copy link
Collaborator

@mr-manuel mr-manuel marked this pull request as draft April 2, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants