Adding Support for EG4-LL 12v BMS #1026
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a driver for EG4-LL 12v BMS.
etc/dbus-serialbattery/dbus-serialbattery.py
docs/docs/general/features.md
docs/docs/general/supported-bms.md
*
self.max_battery_charge_current
andself.max_battery_discharge_current
with values read from the BMSself.unique_identifier
with a unique value to distinguish the BMS in a multiple battery setupdocs/docs/general/install.md
; --------- BMS specific settings ---------
section in theetc/dbus-serialbattery/config.default.ini
Actions
->General
->Actions permissions
the optionAllow all actions and reusable workflows
. Check also in your repository settings underActions
->General
->Workflow permissions
ifRead and write permissions
are selected. After this changes you have to make a new commit, if you don't see any Actions run. This will check your code for Flake8 and Black Lint errors. Here is a short instruction on how to set up Flake8 and Black Lint checks in VS Code. This will save you a lot of time.