Implemented CCL/DCL depending on cell-voltage #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renamed some variables, to differentiate between charge- and discharge current. Now it's possible to choose the Current-Limitation-Mode: classic vs my variant. (Everbody can now implement his own idea, without harming other codes) #Choose the mode for voltage / current limitations in the utils.py: #LIMITATION_MODE = "Classic" # Classic Mode, limitations depending on State of Charge (SoC) LIMITATION_MODE = "WaldemarFech" # WaldemarFech-Mode, limitations depending on min / max cell-voltage #Setup the Voltage- and Current-Values in the utils.py: #Set Steps to reduce charging current. The current will be changed linear between those steps CELL_VOLTAGES_WHILE_CHARGING = [3.55, 3.50, 3.45, 3.30] # first value must be the highest MAX_CHARGE_CURRENT = [ 0, 2, 100, 200] CELL_VOLTAGES_WHILE_DISCHARGING = [2.70, 2.80, 2.90, 3.10] # first value must be the lowest MAX_DISCHARGE_CURRENT = [ 0, 5, 100, 200]
not live tested yet
|
I'll review your change in detail this weekend. |
Louisvdw
approved these changes
Nov 19, 2022
|
See #297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also renamed some variables, to differentiate between charge- and discharge current.
Now it's possible to choose the Current-Limitation-Mode: classic vs my variant. (Everbody can now implement his own idea, without harming other codes) #Choose the mode for voltage / current limitations in the utils.py: #LIMITATION_MODE = "Classic" # Classic Mode, limitations depending on State of Charge (SoC) LIMITATION_MODE = "WaldemarFech" # WaldemarFech-Mode, limitations depending on min / max cell-voltage