Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Traces of OpenGL (API-specific) in the main Renderer (API-agnostic) #48

Conversation

Puddlestomper
Copy link

@Puddlestomper Puddlestomper commented Nov 7, 2019

PR impact (Make sure to add closing keywords)

List of related issues/PRs this will solve:

Impact Issue/PR
Issues this solves Part of TheCherno#140
Other PRs this solves None

Proposed fix (Make sure you've read on how to contribute to Hazel)

Replace the two lines with the relevant calls from the Shader class.
Also merges in the latest Hazel commit.

@LovelySanta
Copy link
Owner

Due to merging the Hazel commits already beforehand onto this branch, I can't squash and merge (would create merge conflicts)

I've manualy pushed it (2530a5b)

@LovelySanta LovelySanta closed this Nov 9, 2019
@Puddlestomper Puddlestomper deleted the maintenanceRemoveOpenGLCalls branch November 11, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants