feat: Add Shorts endpoint #512
Conversation
There was a problem hiding this comment.
In general the pull request looks good, haven't tested it, just a few nits around the code style, performance and not parsing tracking information.
I'll let Luan decide on the naming of things, e.g. the watch route not fully matching the path name and a few mentions of renderer in properties, which YouTube.js tries to stay away from, unless there is already a field that has it without the renderer in it's name.
src/Innertube.ts
Outdated
| @@ -39,6 +41,7 @@ import type { ApiResponse } from './core/Actions.js'; | |||
| import { type IBrowseResponse, type IParsedResponse } from './parser/types/index.js'; | |||
| import type { INextRequest } from './types/index.js'; | |||
| import type { DownloadOptions, FormatOptions } from './types/FormatUtils.js'; | |||
| import {encodeReelSequence} from './proto/index.js'; | |||
There was a problem hiding this comment.
Please add spaces inside the brackets to match the code style used for the other imports, please address it in the other files too.
There was a problem hiding this comment.
Adapted and added a eslint rule to create warnings about this issue
|
Are there any other recommendations left regarding this PR. 😅 |
|
+1 I'd very much to get shorts as well, thanks for the work |
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
Duell10111
force-pushed
the
shorts-endpoint
branch
from
ed89566
to
e2c506a
Compare
Fixed eslint erros as you suggested and rebased PR. :) |
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
Author: Konstantin <duell10111@t-online.de>
Authored-by: Konstantin <duell10111@t-online.de>
This PR should start integrating the short endpoints as discussed here:
#482
As I still do not have the overview over the library, the changes maybe do not fit to the library still.
Any help is welcome. :)