-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(player): improved decipher logic #79
Conversation
- Improve the deciphering logic for Signatures and NTokens. - This makes NToken transforms more than 20x faster - It also improves caching of the player drastically, by only keeping the processed responses in binary format. Bringing down the cache per player from 1.8MB to less than 400 bytes
Great! Do note however that Google is constantly tweaking the microlanguage used in the NToken algorithm, I see this adds a bit of complexity around that and might make it more difficult to fix something if they push a major change. Also, maybe we should include the original typescript files in the same folder alongside the compiled deciphers? Edit: |
A pure Javascript implementation would look pretty much identical to this, its only the enums thats a bit hard to read after the compilation step. |
These improvements where originally written in TypeScript but I did not think it would be appropriate to add a build step to this project, so I compiled it down to JavaScript before adding to this project. You can view the original files here