Support for custom observations (both observation function and observation space) #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @firemankoxd , thanks a lot for these contributions! I will try to review them as soon as possible :) |
|
The PR looks great! Thanks again! :D The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Lucas,
as we discussed in PR-126, I separated the observations to another file and solved the previous issue - where the user might specify only observation function without specifying observation space.
User can now specify the observations by creating class which will be inherited from base
ObservationFunctionclass and adding it as aobservation_classparameter when creatingSumoEnvironmentobject. If the observation class is not defined,DefaultObservationFunctionis used instead, so this change shouldn't affect previous implementations.One thing I am not completely sure of is the
discrete_observation_spaceattribute of theTrafficSignalclass. I didn't find any usage of this attribute so I am not sure if it should be also considered in observations. Or maybe I can just delete that attribute in another commit? 😄 Please, let me know.