WIP: Packet Fragmentation implementation | DO NOT MERGE #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nPost/amethyst-protocol into large_packet_implementation
TimonPost
changed the title
LucioFranco
reviewed
Oct 1, 2018
There was a problem hiding this comment.
This is looking great, lots of comments but mostly questions. Lets address my questions and then ill give this another review. Overall amazing work @TimonPost 👍 .
| // get specific slice of data for fragment | ||
| let fragment_data = &payload[start_fragment_pos..end_fragment_pos]; | ||
|
|
||
| packet_data.add_fragment(&fragment, fragment_data.to_vec()); |
There was a problem hiding this comment.
Do you think there might be a way to avoid this allocation?
There was a problem hiding this comment.
You mean .to_vec? If yes, I am going to try to make everything work with slices I am not happy yet because I do this for multiple places.
|
Very nice work, I mostly just had questions and a few nitpicks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of fragmentation (issue). Looks like it is working, but need to test it more still. So work in progress...
Note that I have looked at this libary which had some basic implementation of fragmentation. It is from the author of gafferongames blogs:
Things I changed:
PacketHeader
This will contain all the header stuff we first had in RawPacket. This will be used for every packet.
Fragment Header
Fragment header the information of the fragments a packet is divided into. The first fragment packet will have two headers. The standard PacketHeader and the Fragment header the following fragments only have the fragment header.
byteorderso that I can control more better how a header gets serialized an deserialized.Still, need to do: