[Fabric] Fix players getting kicked on long taking configuration and make setting the user run earlier #3863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patbox
changed the title
lucko
reviewed
Mar 28, 2024
| } | ||
|
|
||
| @Inject(method = "onReady", at = @At(value = "INVOKE", target = "Lnet/minecraft/server/PlayerManager;onPlayerConnect(Lnet/minecraft/network/ClientConnection;Lnet/minecraft/server/network/ServerPlayerEntity;Lnet/minecraft/server/network/ConnectedClientData;)V", shift = At.Shift.BEFORE), cancellable = true) | ||
| private void beforeConnecttion(ReadyC2SPacket packet, CallbackInfo ci, @Local ServerPlayerEntity player) { |
There was a problem hiding this comment.
Is there not a way to do this with Fabric API? :(
I would prefer to not have to maintain our own event for something as critical (to LuckPerms) as the login event.
There was a problem hiding this comment.
All fabric events happen too late from my testing. This is the earliest point ServerPlayerEntity instance exists and it runs just before rest of server's initialization code does, which should cover all cases (as mods are also likely to check permissions with mixin at any point within the onPlayerConnect). Fabric is just a mixin-heavy platform, so there is no real way to avoid it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit fixes the issues when mods try to check permissions which could happen before luckperm's event could be executed.
Second commit fixes issue where players that took too long to join (for example because of using big resource pack on slow connection), got kicked out because of luckperms