Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup storybook #164

Merged
merged 126 commits into from
Apr 24, 2024
Merged

Setup storybook #164

merged 126 commits into from
Apr 24, 2024

Conversation

abiriadev
Copy link
Member

@abiriadev abiriadev commented Apr 18, 2024

image

Closes #160

πŸ’‘ μ•„λž˜μ—μ„œ 적용된 λͺ¨μŠ΅μ„ 확인해 λ³΄μ„Έμš”!

https://ludo-smp.github.io/ludo-frontend

πŸ’‘ λ‹€μŒ 이슈λ₯Ό ν•΄κ²°ν–ˆμ–΄μš”.

πŸ’‘ 이슈λ₯Ό μ²˜λ¦¬ν•˜λ©΄μ„œ μΆ”κ°€λœ μ½”λ“œκ°€ μžˆμ–΄μš”.

  • 총 69개의 μŠ€ν† λ¦¬ 파일(CSF)을 μΆ”κ°€ν–ˆμ–΄μš”.
  • 자주 μ“°μ΄λŠ” μ»΄ν¬λ„ŒνŠΈμ™€ κ·Έ Props에 JSDoc 주석을 μΆ”κ°€ν–ˆμ–΄μš”
  • iindex.ts둜 μ˜€νƒ€κ°€ 있던 InputText μ»΄ν¬λ„ŒνŠΈμ˜ νŒŒμΌμ„ μ˜¬λ°”λ₯΄κ²Œ κ΅μ •ν–ˆμ–΄μš”: 73b3157


πŸ’‘ ν•„μš”ν•œ ν›„μ†μž‘μ—…μ΄ μžˆμ–΄μš”.

  • export default 및 export const 혼재 방지 #163
  • μ€‘λ³΅λœ μ»΄ν¬λ„ŒνŠΈ / 쓰이지 μ•Šκ±°λ‚˜ λŒ€μ²΄λœ μ»΄ν¬λ„ŒνŠΈ 제거
  • SelectBox, Stack λ“± 후에 κ΅¬ν˜„λœ μ»΄ν¬λ„ŒνŠΈλ“€μ€ 머지 ν›„ 각자 μΆ”κ°€μ μœΌλ‘œ λ¬Έμ„œν™” ν•„μš”
  • 쓰이지 μ•ŠλŠ” Props, λ―Έκ΅¬ν˜„λœ Props 정리
  • μ€‘λ³΅λœ μ»΄ν¬λ„ŒνŠΈ, 쓰이지 μ•ŠλŠ” μ»΄ν¬λ„ŒνŠΈ 제거


πŸ’‘ λ‹€μŒ 자료λ₯Ό μ°Έκ³ ν•˜λ©΄ μ’‹μ•„μš”.

βœ… μ…€ν”„ 체크리슀트

  • 브랜치 μ „λž΅μ— λ§žλŠ” λΈŒλžœμΉ˜μ— PR을 올리고 μžˆμŠ΅λ‹ˆλ‹€. (master/main이 μ•„λ‹™λ‹ˆλ‹€.)
  • 컀밋 메세지λ₯Ό μ»¨λ²€μ…˜μ— λ§žμΆ”μ—ˆμŠ΅λ‹ˆλ‹€.
  • λ³€κ²½ ν›„ μ½”λ“œλŠ” 컴파일러/λΈŒλΌμš°μ € warning/error κ°€ λ°œμƒμ‹œν‚€μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.
  • λ³€κ²½ ν›„ μ½”λ“œλŠ” 기쑴의 ν…ŒμŠ€νŠΈλ₯Ό ν†΅κ³Όν•©λ‹ˆλ‹€.
  • ν…ŒμŠ€νŠΈ μΆ”κ°€κ°€ ν•„μš”ν•œμ§€ κ²€ν† ν•΄λ³΄μ•˜κ³ , ν•„μš”ν•œ 경우 ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
  • docs μˆ˜μ •μ΄ ν•„μš”ν•œμ§€ κ²€ν† ν•΄λ³΄μ•˜κ³ , ν•„μš”ν•œ 경우 docsλ₯Ό μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

```sh
$ yarn dlx storybook@latest init
```

- eslint μˆ˜μ •
- dependencies μΆ”κ°€
- storybook 둜그 파일 λ¬΄μ‹œ
@abiriadev
Copy link
Member Author

@kmin-jeong @hyosin-Jang 리뷰 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€!

@SungHyun627 SungHyun627 requested review from hyosin-Jang and removed request for kmin-jeong April 24, 2024 12:20
Copy link
Collaborator

@SungHyun627 SungHyun627 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storybook μ„€μ • 및 각 μ»΄ν¬λ„ŒνŠΈλ³„ storybook μ½”λ“œ μž‘μ„±ν•˜μ‹  λΆ€λΆ„ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€. storybook λ„μž…μ„ μœ„ν•œ eslint μ„€μ •, UIλ₯Ό controlν•˜κΈ° μœ„ν•œ manager.ts μ½”λ“œ μž‘μ„±, Storybook의 κΈ°λ³Έ ꡬ성을 μœ„ν•œ main.ts μž‘μ„± λ“± 생각보닀 μ‚¬μ „μž‘μ—…μ΄ 많이 ν•„μš”ν–ˆλ˜ 것 κ°™λ„€μš” γ… γ… . κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€πŸ‘. #160μ—μ„œ μƒμ„Ένžˆ μž‘μ„±ν•΄μ£Όμ‹  storybook λ„μž… 이유 및 μ°Έκ³ μžλ£Œμ™€ μž‘μ„±ν•΄μ£Όμ‹  μ»΄ν¬λ„ŒνŠΈλ³„ stories.ts μ½”λ“œ ν™•μΈν•˜μ—¬, μ§€μ†μ μœΌλ‘œ κ°œλ³„ μ»΄ν¬λ„ŒνŠΈλ₯Ό 정리 / λ¬Έμ„œν™”ν•˜λŠ” μž‘μ—… μ§„ν–‰ν•˜κ² μŠ΅λ‹ˆλ‹€. 정말 μˆ˜κ³ λ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€πŸ™

@abiriadev abiriadev merged commit f0c8ff1 into dev Apr 24, 2024
1 check passed
@abiriadev abiriadev deleted the setup-storybook branch April 24, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation λ¦¬νŒ©ν† λ§
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook λ„μž…
3 participants