Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type null is not assignable to type IContent #83

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Conversation

cjxe
Copy link
Contributor

@cjxe cjxe commented Aug 19, 2023

Description

  1. I fixed type 'null' is not assignable to type 'IContent' error
  2. I wrote a unit test in packages/main-library/src/__tests__/index.test.ts to test this change

Test

Test steps

  1. Switch to this branch
  2. Run nvm use 16.14.2 to switch to Node version 16.14.2 (install it using nvm if it's not installed yet)
  3. Run yarn test to run the test files
  4. Run yarn build to build the package

Expected results

  • Test should pass without any errors
  • The package builds without any errors

Further comments

The GH actions tests are failing because the tests are being run on the last commit (which is a broken commit).

To run it on the last commit, follow the steps:
1- reset “develop” branch to latest working commit (1dac19b)
2- sync your “develop” and “main” branch
3- merge this PR. It will be merged to the “develop” branch

Now, the tests should pass; because I ran GH actions on my bug reproduction environment

@cjxe cjxe changed the base branch from main to develop August 19, 2023 08:47
@LuisEnMarroquin LuisEnMarroquin merged commit c243fef into LuisEnMarroquin:develop Aug 24, 2023
1 check failed
@LuisEnMarroquin
Copy link
Owner

cd Music/json-as-xlsx
gck develop
git reset --hard 1dac19b147ad767b9db9fa6be6feae22efce9305
gck main
gpl
git reset --hard origin/main
gpl
gck develop
git push origin develop --force
git merge main
gps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants