Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests-ftp maintenance #18

Closed
emanuil-tolev opened this issue Dec 17, 2015 · 2 comments
Closed

requests-ftp maintenance #18

emanuil-tolev opened this issue Dec 17, 2015 · 2 comments

Comments

@emanuil-tolev
Copy link
Contributor

hey @Lukasa

You say in #10 (comment)

@adrienbrunet This library is definitely far from perfection: it was mostly intended as a joke when I originally wrote it! I'm definitely open to finding someone else to take over maintenance of it and to turn it into something more useful, so if you feel like proposing some pull requests and getting this library up and running into something better, I'll happily consider taking on a maintainer.

What does that mean in immediate practical terms? Do you think it should be rewritten to be more .. in line with whatever best practices there are for requests transport adapters? And some tests.

I think it's a very useful obvious hole for those just looking to interact with FTP in ~2 lines. I'm not offering to be a maintainer since for me that just means trying to do what's needed and make lots of PRs, and if I can make the time for that then presto.

@Lukasa
Copy link
Owner

Lukasa commented Dec 17, 2015

In practical terms it means that this library attracts the bare minimum of my time. It means I do my best to review and merge pull requests when they're provided, and may attempt bug fixes, but that it's just not the focus of my work: I have too many other things to be doing.

In general, if someone finds this useful enough that they'd like it to be "production ready", I'm happy to work with that person to make it possible for them to do so, and in doing so hand control of the library to them. However, if no such person is willing to stand up, then the library will continue more or less in the same way as before.

@emanuil-tolev
Copy link
Contributor Author

In practical terms it means that this library attracts the bare minimum of my time. It means I do my best to review and merge pull requests when they're provided, and may attempt bug fixes, but that it's just not the focus of my work: I have too many other things to be doing.

Sorry, of course - by "immediate practical terms" I meant what did you think was the best direction for the library to take. But it's probably best to just talk about that with the person who does make time for the lib. I'm trying to make time this week and early Jan. If I can resolve most of the issues listed on the issues page I'll have proven to myself I do have the time, and built up a sufficient understanding of the library.

Nothing more to add to this specific issue though, I'll see if I succeed in the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants