Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests that use .options.json #99

Closed
2 tasks done
sidkshatriya opened this issue Jun 14, 2016 · 3 comments
Closed
2 tasks done

Add some tests that use .options.json #99

sidkshatriya opened this issue Jun 14, 2016 · 3 comments
Assignees

Comments

@sidkshatriya
Copy link
Contributor

sidkshatriya commented Jun 14, 2016

As a by product of #96, a useful testing feature was built and that was the ability for a test to get arbitrary options from a .options.json file. See PR #98 for more details.

We can use this feature to add a couple of tests that will test some additional aspects of the amp-library:

  • Add a test to check the addition of statistics html comment. Make sure that only the relevant statistics comments gets compared (e.g. number of tags processed) and not things like date (which would vary from run to run). For this make appropriate code changes.
  • Add a test to see if <div placeholder> text is generated in the video to amp-video conversion.
@sidkshatriya
Copy link
Contributor Author

All items complete on this ticket and the PR was merged to master. Closing.

@sidkshatriya
Copy link
Contributor Author

I had an idea for some more tests. Re-opening this ticket.

@sidkshatriya
Copy link
Contributor Author

There are 2 new tests.

  • Test to test the no_lines = false feature (i.e. line number in "ampized" output)
  • Test to test the diff feature

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant