Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User tag selector blacklist #98

Merged
merged 7 commits into from
Jun 14, 2016
Merged

Conversation

sidkshatriya
Copy link
Contributor

See #96

@sidkshatriya sidkshatriya self-assigned this Jun 13, 2016
@sidkshatriya
Copy link
Contributor Author

This PR add the following features:

  • Adds ability for phpunit tests to load options from a .options.json file
  • Adds ability for amp-console to load options using the (new) --options=filename command line option
  • Adds ability to pass certain CSS selectors as "blacklist selectors". If a blacklist selector is found, the tag is removed

@sidkshatriya sidkshatriya merged commit e4b7393 into master Jun 14, 2016
@sidkshatriya sidkshatriya deleted the user-tag-selector-blacklist branch June 14, 2016 08:53
@sidkshatriya
Copy link
Contributor Author

I think we can merge this to master - If there are any tweaks required we can always include them later.

@marretjeca this is now available in the master branch of the library and you no longer need to switch to a specific branch of the amp-library.

sidkshatriya added a commit that referenced this pull request Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant