Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

99 options json tests #100

Merged
merged 3 commits into from
Jun 14, 2016
Merged

99 options json tests #100

merged 3 commits into from
Jun 14, 2016

Conversation

sidkshatriya
Copy link
Contributor

See #99

Essentially in testing_mode we will output the string '[template]'
for statistics for things like date, memory usage etc. We don't
want the literal values to be compared during phpunit testing as
those values change from run to run. Where we don't want '[template]'
to be output is for instance the number of tags processed which
should be stable from run to run.
@sidkshatriya sidkshatriya self-assigned this Jun 14, 2016
@sidkshatriya
Copy link
Contributor Author

They way we make sure that things like date etc. do not cause a diff issue in phpunit is handled in df03865

From commit message:

Essentially in testing_mode we will output the string '[template]'
for statistics for things like date, memory usage etc. We don't
want the literal values to be compared during phpunit testing as
those values change from run to run. Where we don't want '[template]'
to be output is for instance the number of tags processed which
should be stable from run to run.

@sidkshatriya sidkshatriya merged commit 95f3051 into master Jun 14, 2016
@sidkshatriya
Copy link
Contributor Author

This was merged to master.

@sidkshatriya sidkshatriya deleted the 99-options-json-tests branch June 14, 2016 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant