relax url validation for facebook video embeds #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebastianbenz could you merge this please? trying to bring POPSUGAR amp-library up to speed with this one, since we diverged since last september |
|
@sigginet could you merge this please? trying to bring POPSUGAR amp-library up to speed with this one, since we diverged since last september |
|
Merged @obeyer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
existing regex would not consider perfectly fine fb video urls valid, like
https://www.facebook.com/PopSugar/videos/vb.112402358796244/848573591845780/?type=2&theater¬if_t=live_video_explicit¬if_id=1484099141368371