Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Selenium images / Fix php-webdriver #265

Open
2 tasks
justafish opened this issue Sep 28, 2023 · 6 comments
Open
2 tasks

Update Selenium images / Fix php-webdriver #265

justafish opened this issue Sep 28, 2023 · 6 comments

Comments

@justafish
Copy link
Member

justafish commented Sep 28, 2023

Our Selenium images are currently > 1 year old, and are stuck there initially because of instaclick/php-webdriver#118
Newer browsers have dropped support for JSON wire protocol.

@justafish
Copy link
Member Author

PR to minkphp/MinkSelenium2Driver minkphp/MinkSelenium2Driver#372

@justafish
Copy link
Member Author

I've forked the packages as upstream won't accept the changes. https://www.drupal.org/project/drupal/issues/3240792

Currently blocked on some changes that need making to drupal.org's GitLab CI https://www.drupal.org/project/infrastructure/issues/3418417

@justafish
Copy link
Member Author

Currently working on getting the tests running in Firefox so we can verify that the changes that need to happen to Drupal core for w3c compatibility are validated https://git.drupalcode.org/project/drupal/-/merge_requests/7104

@alexanderpatriciop
Copy link
Collaborator

In a project using the :has (https://developer.mozilla.org/en-US/docs/Web/CSS/:has) on a CSS selector, the styles are not applying due to the Chromium and Firefox versions, so I need to update the version of them.

@elvism-lullabot
Copy link
Collaborator

@justafish could you review the changes above we made? (internal PR) and weigh in suggesting whether we should upgrade the images versions on our side or on the drainpipe/dev repo

@justafish
Copy link
Member Author

justafish added a commit that referenced this issue Aug 20, 2024
justafish added a commit that referenced this issue Aug 20, 2024
* Issue #265: Upgrade Selenium images

* Fix MINK_DRIVER_ARGS

* Switch to lullabot/mink-selenium2-driver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants