Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid uberName in getLibraryOverview (fixes #28) #29

Merged
merged 2 commits into from
Jun 26, 2019

Conversation

JPSchellenberg
Copy link
Member

Hey,

this PR fixes the invalid uberName in the getLibraryOverview-function.
The uberName needs a space between the name and version, not a dash.

@JPSchellenberg JPSchellenberg self-assigned this Jun 25, 2019
@JPSchellenberg JPSchellenberg added [type] bug Something isn't working (resulting in patch-version) H5P-Editor labels Jun 25, 2019
@JPSchellenberg JPSchellenberg added this to in progress in H5P via automation Jun 25, 2019
@JPSchellenberg JPSchellenberg merged commit 33f4f86 into master Jun 26, 2019
H5P automation moved this from in progress to done Jun 26, 2019
@JPSchellenberg JPSchellenberg deleted the fix/28-invalid-uberName branch July 3, 2019 11:42
sr258 added a commit that referenced this pull request Feb 7, 2021
JPSchellenberg added a commit that referenced this pull request Feb 16, 2021
* refactor(ajax endpoint): moved Ajax endpoint logic to own class

* refactor(ajax endpoint): moved POST Ajax endpoint logic

* test(ajax endpoint): added tests

* refactor(ajax endpoint): moved get file logic to own class

* refactor(ajax endpoint): moved get library file to new class

* refactor(ajax endpoint): added parameter checks

* docs(ajax endpoint): improved documentation

* docs(ajax endpoint): improved documentation

* feat(customization): improved customization options

* feat(customization): added alterLibraryFiles

* feat(customization): added alterLibrarySemantics

* refactor(customization): the LibraryManager is constructed with hook

* refactor(customization): added options to instanciation of H5PEditor

* feat(customization): added alterLibraryLanguageFile and docs

* fix(customization): fixed error in language getter

* refactor(customization): improved consistency

* docs(customization): extended documentation and improved consistency

* refactor(library storage): converted streams to readables

* feat(caching): added CachedLibraryStorage

* fix(caching): correct CachedLibraryStorage

* test(caching): added and improved tests

* test(caching): added and improved tests

* test(caching): extended tests

* refactor(caching)!: changed getInstalledLibraryNames to allow caching

The array parameter was taken over from the structure of the PHP
implementation and was never used anyway.

* refactor(caching): now caches all files

* feat(caching): added more methods to caching

* docs(caching): added docs; example uses cache

* fix(caching): disabled cache for e2e tests

* feat(file uploads): file uploads can also be stored in the file system

* test(package validator): corrected tests

* refactor(merge): merged upstream

* test(e2e): e2e test cache now set with cross-env

* docs(documentation): restructed documentation

* fix(xss): checked H5PAjaxEndpoint for xss weaknesses

* test(ajax router): corrected test for upstream change

* refactor(ajax router): exported H5PAjaxEndpoint

* feat(caching): added cached key-value storage

* fix(caching): added support for Redis caching

* feat(example): added cluster mode

* docs(example): corrected cluster docs

* feat(browser caching): added resource caching support

* test(browser caching): corrected tests

* feat(browser caching): added cache buster to integration

* fix(browser caching): removed cache buster from generated libraryUrl

* fix(html exporter): query strings removed from filenames

* test(package exporter): increased test timeout

* refactor(merge): added missing packages

* test(e2e): added caching

* fix(merge): fixed merge errors

* fix(merge): corrected merge errors

* test(e2e): improved test robustness

* fix(xss): remove overeager escaping of plain text (#17)

* fix(xss): removed overeager escaping of plain text

* test(xss): removed old tests

* chore(deps): install lerna

* refactor(monorepo): run lerna init

* refactor(h5p-server): move h5p-server to packages

* refactor(monorepo): adjust scripts

* refactor(h5p-examples): separate h5p-examples from h5p-server

* test(h5p-server): repair broken paths

* refactor(h5p-test-server): rename h5p-examples to h5p-test-server

* refactor(monorepo): move e2e tests to h5p-examples

* test(e2e): fix import

* chore(deps): update packages

* chore(deps): remove package dependencies from root

* refactor(h5p-express-adapter): extract h5p-express-adapter

* test(h5p-express-adapter): get tests running again

* refactor(h5p-express-adapter): make h5p-express-adapter releaseable

* refactor(h5p-express): rename h5p-express-adapter to h5p-express

* refactor(h5p-mongos3): extract h5p-mongos3 from h5p-server

* ci(tests): run tests only on refactor/monorepo branch

* ci(tests): revert branch filter

* fix(exports): added export for IUrlGenerator (#29)

* chore(deps): updated package-lock

* refactor(h5p-html-exporter): extract h5p-html-exporter

* refactor(h5p-express): use @lumieducation/h5p-mongos3

* v7.0.0-alpha.0

* v7.0.0-alpha.1

* refactor(h5p-server): remove unneeded dependencies

* refactor(h5p-examples): move dockerfile

* test(common): share common test data across packages

* test(h5p-examples): move test data

* fix(install): fix install scripts

* docs(gitbook): add gitbook config

* GitBook: [master] 30 pages and 2 assets modified

* GitBook: [refactor/monorepo] 17 pages and 2 assets modified

* fix(deps): downgrade i18next-http-middleware to 3.0.6 in h5p-examples

* fix(monorep): corrected paths for scripts and assets

* refactor(db): moved docker compose and updated db test

* test(e2e): fixed e2e puppeteer type dependency

* test(e2e): made puppeteer tests headful

* test(h5p-html-exporter): fix wrong paths

* test(husky): add special husky prepush command

* ci(cache): add packages to cache

* ci(workspace): add packages to workspace

* ci(puppeteer): add NODE_ENV=development env

the NODE_ENV=development env should be set

* ci(install): run npm ci instead of npm install

npm ci fails if package.json and package-lock.json are not in sync, so we get an extra check

* ci(puppeteer): add puppeteer orb for chrome headless mode

* ci(install): revert to npm install

* ci(unittests): use browser image

* test(jest): run unit tests from root

* test(jest): add logHeapUsage and maxWorkers flags

* test(integration): fix integration tests

* test(db): fix db tests

* test(e2e): fix h5p-examples build

* ci(puppeteer): remove orb

* refactor(git): add h5p-html-exporter test files to gitignore

* refactor(db): filter with root prefix for temporary storage lifecycle

* test(example): e2e tests now headless

* feat(webcomponents): add webcomponents

* feat(react): add h5p-react package

* chore(deps): update deps

* test(lint): make tslint happy

* ci(release): release only from release-branch

* ci(db-tests): disable db-tests

* ci(db-tests): remove db-test from requirements for release

* ci(e2e-tests): disable e2e-tests

Co-authored-by: JPSchellenberg <jps@Lumi.education>
sr258 added a commit that referenced this pull request Feb 19, 2021
* chore(deps): update dependency aws-sdk to v2.820.0

* chore(deps): lock file maintenance

* chore(deps): update dependency aws-sdk to v2.821.0

* chore(deps): update dependency aws-sdk to v2.822.0

* chore(deps): update dependency aws-sdk to v2.823.0

* chore(deps): update dependency husky to v4.3.7

* chore(deps): update dependency aws-sdk to v2.824.0

* chore(deps): lock file maintenance

* chore(deps): update dependency aws-sdk to v2.825.0

* chore(deps): update dependency @types/jest to v26.0.20

* chore(deps): update dependency @types/express to v4.17.10

* chore(deps): update dependency express-fileupload to v1.2.1

* chore(deps): update dependency aws-sdk to v2.826.0

* chore(deps): update dependency @types/express to v4.17.11

* chore(deps): update dependency semantic-release to v17.3.2

* chore(deps): update dependency aws-sdk to v2.827.0

* chore(deps): update dependency aws-sdk to v2.828.0

* chore(deps): update dependency husky to v4.3.8

* chore(deps): update dependency semantic-release to v17.3.3

* chore(deps): update dependency supertest to v6.1.1

* chore(deps): update dependency semantic-release to v17.3.4

* chore(deps): update dependency semantic-release to v17.3.5

* chore(deps): update dependency aws-sdk to v2.829.0

* chore(deps): update dependency i18next-fs-backend to v1.0.8

* chore(deps): update dependency semantic-release to v17.3.6

* chore(deps): update dependency aws-sdk to v2.831.0

* chore(deps): update dependency @types/sanitize-html to v1.27.1

* chore(deps): update dependency semantic-release to v17.3.7

* chore(deps): update dependency supertest to v6.1.2

* chore(deps): update dependency aws-sdk to v2.832.0

* chore(deps): lock file maintenance

* chore(deps): update dependency supertest to v6.1.3

* chore(deps): update dependency aws-sdk to v2.833.0

* chore(deps): update dependency aws-sdk to v2.834.0

* chore(deps): update dependency ts-jest to v26.5.0

* chore(deps): update dependency i18next to v19.8.5

* chore(deps): lock file maintenance

* chore(deps): update dependency mongodb to v3.6.4

* chore(deps): update dependency i18next to v19.8.7

* chore(deps): update dependency @types/react to v17.0.1

* chore(deps): update dependency aws-sdk to v2.835.0

* chore(deps): update dependency start-server-and-test to v1.12.0

* chore(deps): update dependency aws-sdk to v2.836.0

* refactor(monorepo) (#1040)

* refactor(ajax endpoint): moved Ajax endpoint logic to own class

* refactor(ajax endpoint): moved POST Ajax endpoint logic

* test(ajax endpoint): added tests

* refactor(ajax endpoint): moved get file logic to own class

* refactor(ajax endpoint): moved get library file to new class

* refactor(ajax endpoint): added parameter checks

* docs(ajax endpoint): improved documentation

* docs(ajax endpoint): improved documentation

* feat(customization): improved customization options

* feat(customization): added alterLibraryFiles

* feat(customization): added alterLibrarySemantics

* refactor(customization): the LibraryManager is constructed with hook

* refactor(customization): added options to instanciation of H5PEditor

* feat(customization): added alterLibraryLanguageFile and docs

* fix(customization): fixed error in language getter

* refactor(customization): improved consistency

* docs(customization): extended documentation and improved consistency

* refactor(library storage): converted streams to readables

* feat(caching): added CachedLibraryStorage

* fix(caching): correct CachedLibraryStorage

* test(caching): added and improved tests

* test(caching): added and improved tests

* test(caching): extended tests

* refactor(caching)!: changed getInstalledLibraryNames to allow caching

The array parameter was taken over from the structure of the PHP
implementation and was never used anyway.

* refactor(caching): now caches all files

* feat(caching): added more methods to caching

* docs(caching): added docs; example uses cache

* fix(caching): disabled cache for e2e tests

* feat(file uploads): file uploads can also be stored in the file system

* test(package validator): corrected tests

* refactor(merge): merged upstream

* test(e2e): e2e test cache now set with cross-env

* docs(documentation): restructed documentation

* fix(xss): checked H5PAjaxEndpoint for xss weaknesses

* test(ajax router): corrected test for upstream change

* refactor(ajax router): exported H5PAjaxEndpoint

* feat(caching): added cached key-value storage

* fix(caching): added support for Redis caching

* feat(example): added cluster mode

* docs(example): corrected cluster docs

* feat(browser caching): added resource caching support

* test(browser caching): corrected tests

* feat(browser caching): added cache buster to integration

* fix(browser caching): removed cache buster from generated libraryUrl

* fix(html exporter): query strings removed from filenames

* test(package exporter): increased test timeout

* refactor(merge): added missing packages

* test(e2e): added caching

* fix(merge): fixed merge errors

* fix(merge): corrected merge errors

* test(e2e): improved test robustness

* fix(xss): remove overeager escaping of plain text (#17)

* fix(xss): removed overeager escaping of plain text

* test(xss): removed old tests

* chore(deps): install lerna

* refactor(monorepo): run lerna init

* refactor(h5p-server): move h5p-server to packages

* refactor(monorepo): adjust scripts

* refactor(h5p-examples): separate h5p-examples from h5p-server

* test(h5p-server): repair broken paths

* refactor(h5p-test-server): rename h5p-examples to h5p-test-server

* refactor(monorepo): move e2e tests to h5p-examples

* test(e2e): fix import

* chore(deps): update packages

* chore(deps): remove package dependencies from root

* refactor(h5p-express-adapter): extract h5p-express-adapter

* test(h5p-express-adapter): get tests running again

* refactor(h5p-express-adapter): make h5p-express-adapter releaseable

* refactor(h5p-express): rename h5p-express-adapter to h5p-express

* refactor(h5p-mongos3): extract h5p-mongos3 from h5p-server

* ci(tests): run tests only on refactor/monorepo branch

* ci(tests): revert branch filter

* fix(exports): added export for IUrlGenerator (#29)

* chore(deps): updated package-lock

* refactor(h5p-html-exporter): extract h5p-html-exporter

* refactor(h5p-express): use @lumieducation/h5p-mongos3

* v7.0.0-alpha.0

* v7.0.0-alpha.1

* refactor(h5p-server): remove unneeded dependencies

* refactor(h5p-examples): move dockerfile

* test(common): share common test data across packages

* test(h5p-examples): move test data

* fix(install): fix install scripts

* docs(gitbook): add gitbook config

* GitBook: [master] 30 pages and 2 assets modified

* GitBook: [refactor/monorepo] 17 pages and 2 assets modified

* fix(deps): downgrade i18next-http-middleware to 3.0.6 in h5p-examples

* fix(monorep): corrected paths for scripts and assets

* refactor(db): moved docker compose and updated db test

* test(e2e): fixed e2e puppeteer type dependency

* test(e2e): made puppeteer tests headful

* test(h5p-html-exporter): fix wrong paths

* test(husky): add special husky prepush command

* ci(cache): add packages to cache

* ci(workspace): add packages to workspace

* ci(puppeteer): add NODE_ENV=development env

the NODE_ENV=development env should be set

* ci(install): run npm ci instead of npm install

npm ci fails if package.json and package-lock.json are not in sync, so we get an extra check

* ci(puppeteer): add puppeteer orb for chrome headless mode

* ci(install): revert to npm install

* ci(unittests): use browser image

* test(jest): run unit tests from root

* test(jest): add logHeapUsage and maxWorkers flags

* test(integration): fix integration tests

* test(db): fix db tests

* test(e2e): fix h5p-examples build

* ci(puppeteer): remove orb

* refactor(git): add h5p-html-exporter test files to gitignore

* refactor(db): filter with root prefix for temporary storage lifecycle

* test(example): e2e tests now headless

* feat(webcomponents): add webcomponents

* feat(react): add h5p-react package

* chore(deps): update deps

* test(lint): make tslint happy

* ci(release): release only from release-branch

* ci(db-tests): disable db-tests

* ci(db-tests): remove db-test from requirements for release

* ci(e2e-tests): disable e2e-tests

Co-authored-by: JPSchellenberg <jps@Lumi.education>

* chore(deps): update package-lock.json

* chore(deps): pin dependencies

* chore(deps): update dependency @types/react to v16.14.4

* chore(deps): update dependency @types/resize-observer-browser to v0.1.5

* chore(deps): update dependency cross-env to v7.0.3

* chore(deps): update dependency fs-extra to v9.1.0

* fix(deps): update dependency aws-sdk to v2.845.0

* fix(deps): update dependency mongodb to v3.6.4 (#1056)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency puppeteer to v7.1.0 (#1058)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* fix(deps): update dependency react to v16.14.0 (#1057)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* fix(h5p-server): missing translations when language was not found (#1063)

* ci(release): use lerna for release-process

* fix(deps): update dependency aws-sdk to v2.846.0

* chore(deps): update dependency i18next to v19.8.9

* Pull back release info from release branch (#1067)

* ci(release): fix wrong command

* ci(release): add git email and username

* v7.0.0

* ci(cache): add webcomponents and react to cache

* v7.0.1

Co-authored-by: Lumi <c@Lumi.education>

* fix(deps): update dependency react to v17 (#1059)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* fix(deps): update dependency aws-sdk to v2.847.0

* fix(dependencies): removed package locks

* refactor(h5p-rest-example): corrected internal package references

* fix(h5p-examples): corrected server-side example

* fix(h5p-rest-example): dependencies

* chore(deps): update package-lock.json

* feat(webcomponents): filter statements by contentId

* fix(h5p-rest-example): added missing deps

* fix(deps): corrected dependencies of root

* chore(deps): updated package-lock

* chore(deps): aligned express types version

* fix(deps): reverted i18next-http-middleware

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: JPSchellenberg <jps@Lumi.education>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lumi <c@Lumi.education>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
H5P-Editor [type] bug Something isn't working (resulting in patch-version)
Projects
No open projects
H5P
  
done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant