fix(error handling): server deals more gracefully with invalid content #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will add the redux stuff, so that a correct error message will be displayed as snackbar. |
|
Currently only text fields are validated by h5p-server. Invalid text fields can be caused by:
Weirdly the examples above currently pass validation in Lumi. When I played around, I saw this issue, not sure why it's not reproducible. |
|
I can not reproduce any errors.. Do you still want to merge this PR? |
|
Yes, it improves error handling. |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 1, 2021
# [0.5.0](v0.4.0...v0.5.0) (2021-02-01) ### Bug Fixes * **analytics-import:** folder with dots in their name can be imported ([#1205](#1205)) ([7f4b999](7f4b999)) * **config:** broken/missing configs dealt with gracefully ([#1137](#1137)) ([729f997](729f997)) * **configuration:** config allows larger file sizes ([#1127](#1127)) ([5ef7523](5ef7523)) * **deps:** pin dependencies ([e87d68c](e87d68c)) * **deps:** update dependency @material-ui/core to v4.11.3 ([6875f02](6875f02)) * **deps:** update dependency @sentry/browser to v5.29.2 ([475c48a](475c48a)) * **deps:** update dependency @sentry/electron to v2.1.0 ([#1154](#1154)) ([260087c](260087c)) * **deps:** update dependency @sentry/electron to v2.2.0 ([1ab4ac1](1ab4ac1)) * **deps:** update dependency @testing-library/jest-dom to v5.11.8 ([eaa0cd8](eaa0cd8)) * **deps:** update dependency @testing-library/jest-dom to v5.11.9 ([#1155](#1155)) ([6510d76](6510d76)) * **deps:** update dependency @testing-library/react to v11.2.2 ([5a717cf](5a717cf)) * **deps:** update dependency @testing-library/react to v11.2.3 ([#1144](#1144)) ([227519b](227519b)) * **deps:** update dependency @testing-library/user-event to v12.6.0 ([0cf08f2](0cf08f2)) * **deps:** update dependency @testing-library/user-event to v12.6.1 ([982b227](982b227)) * **deps:** update dependency @testing-library/user-event to v12.6.2 ([d47d60a](d47d60a)) * **deps:** update dependency @types/jest to v26.0.19 ([54198bc](54198bc)) * **deps:** update dependency @types/jest to v26.0.20 ([#1140](#1140)) ([72b8776](72b8776)) * **deps:** update dependency @types/node to v12.19.11 ([8986fdb](8986fdb)) * **deps:** update dependency @types/node to v12.19.12 ([4b9f75c](4b9f75c)) * **deps:** update dependency @types/node to v12.19.13 ([#1156](#1156)) ([f155ddc](f155ddc)) * **deps:** update dependency @types/node to v12.19.14 ([#1175](#1175)) ([3a13e7e](3a13e7e)) * **deps:** update dependency @types/node to v12.19.15 ([dd999b5](dd999b5)) * **deps:** update dependency @types/react to v16.14.2 ([de82c3d](de82c3d)) * **deps:** update dependency @types/react to v17 ([#1108](#1108)) ([7151f05](7151f05)) * **deps:** update dependency @types/react-dom to v16.9.10 ([3943396](3943396)) * **deps:** update dependency @types/react-dom to v17 ([#1109](#1109)) ([eb583b9](eb583b9)) * **deps:** update dependency electron-log to v4.3.1 ([95edbe3](95edbe3)) * **deps:** update dependency express-fileupload to v1.2.1 ([#1153](#1153)) ([f37d962](f37d962)) * **deps:** update dependency fs-extra to v9.1.0 ([8c08202](8c08202)) * **deps:** update dependency h5p-nodejs-library to v6.1.3 ([f554fe9](f554fe9)) * **deps:** update dependency h5p-nodejs-library to v6.2.0 ([a15a7dc](a15a7dc)) * **deps:** update dependency i18next to v19.8.5 ([49a03ae](49a03ae)) * **deps:** update dependency i18next-fs-backend to v1.0.8 ([7111875](7111875)) * **deps:** update dependency nucleus-nodejs to v3.0.8 ([1866bd8](1866bd8)) * **deps:** update dependency react-scripts to v4.0.1 ([3f673fd](3f673fd)) * **deps:** update dependency socket.io to v2.4.1 ([#1141](#1141)) ([c3e7b8c](c3e7b8c)) * **deps:** update dependency typescript to v4.1.3 ([ed43a7d](ed43a7d)) * **deps:** update dependency web-vitals to v1 ([#1110](#1110)) ([94c154b](94c154b)) * **deps:** update dependency web-vitals to v1.1.0 ([ecbb6a0](ecbb6a0)) * **deps:** update h5p-react to v0.1.2 ([#1146](#1146)) ([5a0d450](5a0d450)) * **deps:** update h5p-server to v7.0.0-alpha.1 ([#1208](#1208)) ([2882b9e](2882b9e)) * **deps:** update mui monorepo to v4.11.2 ([e55078d](e55078d)) * **deps:** update sentry monorepo to v5.30.0 ([#1160](#1160)) ([654dcaa](654dcaa)) * **deps:** update socket.io packages to v2.4.0 ([0da5e88](0da5e88)) * **dev tools:** corrected dev tool setup ([#1126](#1126)) ([99c6695](99c6695)) * **devtools-start:** fix missing path on npm start ([#1133](#1133)) ([417c9b1](417c9b1)) * **editor:** localization files are found correctly ([#1171](#1171)) ([9480c2d](9480c2d)) * **error handling:** server deals more gracefully with invalid content ([#1174](#1174)) ([10010e1](10010e1)) * **multi instances:** old content isn't deleted on startup ([#1145](#1145)) ([8605612](8605612)) * **player:** content resizes with window ([#1142](#1142)) ([b50cd04](b50cd04)) * **saving:** last change is always saved now ([#1170](#1170)) ([9c2eb34](9c2eb34)) * **sentry:** deactivate sentry ([#1147](#1147)) ([866453c](866453c)) * **ui:** display a backbutton if not in launchpad ([#1209](#1209)) ([72c6bc1](72c6bc1)) * **windows:** config file created correctly on windows ([#1115](#1115)) ([f3113e0](f3113e0)) ### Features * **analytics:** add analytics and xapi-reporter ([#1196](#1196)) ([daa02d2](daa02d2)) * **gui:** overhaul save & export options ([#1134](#1134)) ([e01192e](e01192e)) * **htmlexport:** add HTML Export ([#1094](#1094)) ([a58b899](a58b899)), closes [#1091](#1091) * **notifications:** reenable notifications ([#1135](#1135)) ([1e95e3c](1e95e3c)) * **server:** in-memory cache speeds up editor load times ([#1125](#1125)) ([7e2a35b](7e2a35b)) * **ui:** re-added custom h5p styles ([#1138](#1138)) ([d4e8f34](d4e8f34))
github-actions bot
pushed a commit
that referenced
this pull request
Feb 1, 2021
# [0.5.0](v0.4.0...v0.5.0) (2021-02-01) ### Bug Fixes * **analytics-import:** folder with dots in their name can be imported ([#1205](#1205)) ([7f4b999](7f4b999)) * **config:** broken/missing configs dealt with gracefully ([#1137](#1137)) ([729f997](729f997)) * **configuration:** config allows larger file sizes ([#1127](#1127)) ([5ef7523](5ef7523)) * **deps:** pin dependencies ([e87d68c](e87d68c)) * **deps:** update dependency @material-ui/core to v4.11.3 ([6875f02](6875f02)) * **deps:** update dependency @sentry/browser to v5.29.2 ([475c48a](475c48a)) * **deps:** update dependency @sentry/electron to v2.1.0 ([#1154](#1154)) ([260087c](260087c)) * **deps:** update dependency @sentry/electron to v2.2.0 ([1ab4ac1](1ab4ac1)) * **deps:** update dependency @testing-library/jest-dom to v5.11.8 ([eaa0cd8](eaa0cd8)) * **deps:** update dependency @testing-library/jest-dom to v5.11.9 ([#1155](#1155)) ([6510d76](6510d76)) * **deps:** update dependency @testing-library/react to v11.2.2 ([5a717cf](5a717cf)) * **deps:** update dependency @testing-library/react to v11.2.3 ([#1144](#1144)) ([227519b](227519b)) * **deps:** update dependency @testing-library/user-event to v12.6.0 ([0cf08f2](0cf08f2)) * **deps:** update dependency @testing-library/user-event to v12.6.1 ([982b227](982b227)) * **deps:** update dependency @testing-library/user-event to v12.6.2 ([d47d60a](d47d60a)) * **deps:** update dependency @types/jest to v26.0.19 ([54198bc](54198bc)) * **deps:** update dependency @types/jest to v26.0.20 ([#1140](#1140)) ([72b8776](72b8776)) * **deps:** update dependency @types/node to v12.19.11 ([8986fdb](8986fdb)) * **deps:** update dependency @types/node to v12.19.12 ([4b9f75c](4b9f75c)) * **deps:** update dependency @types/node to v12.19.13 ([#1156](#1156)) ([f155ddc](f155ddc)) * **deps:** update dependency @types/node to v12.19.14 ([#1175](#1175)) ([3a13e7e](3a13e7e)) * **deps:** update dependency @types/node to v12.19.15 ([dd999b5](dd999b5)) * **deps:** update dependency @types/react to v16.14.2 ([de82c3d](de82c3d)) * **deps:** update dependency @types/react to v17 ([#1108](#1108)) ([7151f05](7151f05)) * **deps:** update dependency @types/react-dom to v16.9.10 ([3943396](3943396)) * **deps:** update dependency @types/react-dom to v17 ([#1109](#1109)) ([eb583b9](eb583b9)) * **deps:** update dependency electron-log to v4.3.1 ([95edbe3](95edbe3)) * **deps:** update dependency express-fileupload to v1.2.1 ([#1153](#1153)) ([f37d962](f37d962)) * **deps:** update dependency fs-extra to v9.1.0 ([8c08202](8c08202)) * **deps:** update dependency h5p-nodejs-library to v6.1.3 ([f554fe9](f554fe9)) * **deps:** update dependency h5p-nodejs-library to v6.2.0 ([a15a7dc](a15a7dc)) * **deps:** update dependency i18next to v19.8.5 ([49a03ae](49a03ae)) * **deps:** update dependency i18next-fs-backend to v1.0.8 ([7111875](7111875)) * **deps:** update dependency nucleus-nodejs to v3.0.8 ([1866bd8](1866bd8)) * **deps:** update dependency react-scripts to v4.0.1 ([3f673fd](3f673fd)) * **deps:** update dependency socket.io to v2.4.1 ([#1141](#1141)) ([c3e7b8c](c3e7b8c)) * **deps:** update dependency typescript to v4.1.3 ([ed43a7d](ed43a7d)) * **deps:** update dependency web-vitals to v1 ([#1110](#1110)) ([94c154b](94c154b)) * **deps:** update dependency web-vitals to v1.1.0 ([ecbb6a0](ecbb6a0)) * **deps:** update h5p-react to v0.1.2 ([#1146](#1146)) ([5a0d450](5a0d450)) * **deps:** update h5p-server to v7.0.0-alpha.1 ([#1208](#1208)) ([2882b9e](2882b9e)) * **deps:** update mui monorepo to v4.11.2 ([e55078d](e55078d)) * **deps:** update sentry monorepo to v5.30.0 ([#1160](#1160)) ([654dcaa](654dcaa)) * **deps:** update socket.io packages to v2.4.0 ([0da5e88](0da5e88)) * **dev tools:** corrected dev tool setup ([#1126](#1126)) ([99c6695](99c6695)) * **devtools-start:** fix missing path on npm start ([#1133](#1133)) ([417c9b1](417c9b1)) * **editor:** localization files are found correctly ([#1171](#1171)) ([9480c2d](9480c2d)) * **error handling:** server deals more gracefully with invalid content ([#1174](#1174)) ([10010e1](10010e1)) * **multi instances:** old content isn't deleted on startup ([#1145](#1145)) ([8605612](8605612)) * **player:** content resizes with window ([#1142](#1142)) ([b50cd04](b50cd04)) * **saving:** last change is always saved now ([#1170](#1170)) ([9c2eb34](9c2eb34)) * **sentry:** deactivate sentry ([#1147](#1147)) ([866453c](866453c)) * **ui:** display a backbutton if not in launchpad ([#1209](#1209)) ([72c6bc1](72c6bc1)) * **windows:** config file created correctly on windows ([#1115](#1115)) ([f3113e0](f3113e0)) ### Features * **analytics:** add analytics and xapi-reporter ([#1196](#1196)) ([daa02d2](daa02d2)) * **gui:** overhaul save & export options ([#1134](#1134)) ([e01192e](e01192e)) * **htmlexport:** add HTML Export ([#1094](#1094)) ([a58b899](a58b899)), closes [#1091](#1091) * **notifications:** reenable notifications ([#1135](#1135)) ([1e95e3c](1e95e3c)) * **server:** in-memory cache speeds up editor load times ([#1125](#1125)) ([7e2a35b](7e2a35b)) * **ui:** re-added custom h5p styles ([#1138](#1138)) ([d4e8f34](d4e8f34))
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1168